Loading...
 
Development

Development


Integrator in 1.8 has bugs

posts: 5

Greetings:

Been trying out 1.8 release straight out of CVS and I found a couple of bugs in $tikiwiki_root/lib/integrator/integrator.php; these bugs manifest when one is trying to modify an existing repository or existing rule.

The bugs that I found are in the following two functions:
1. add_replace_repository
2. add_replace_rule

In both the fix is to bind the query with the appropriate number of parameters. For instance in add_replace_repository, this statement
should be used for insert:
$result = $tikilib->query($query, array($name, $path, $start, $css, $vis, $cacheable, $exp, $descr));
and this statement should be used for update:
$result = $tikilib->query($query, array($name, $path, $start, $css, $vis, $cacheable, $exp, $descr,(int) $repID));

In the existing code, the updates fail because they miss $repID or $ruleID parameter respectively.


Feeling too lazy to file a bug report. Let me know if this is not the appropriate forum to post such messages.

Vijay Aswadhati

posts: 1001 Canada
Yes, this forum is more for discussions, you definitely want a bug report tracker here. It's not harder to do :-)

posts: 1001 Canada
Those were fixed one by one with revisions 1.22.2.1 and 1.22.2.2 today.

Upcoming Events

1)  21 Mar 2024 18:00 GMT-0000
Tiki Roundtable Meeting
2)  25 Mar 2024 17:00 GMT-0000
29th anniversary WikiBirthday (With Ward Cunningham)
3)  18 Apr 2024 18:00 GMT-0000
Tiki Roundtable Meeting
4)  16 May 2024 18:00 GMT-0000
Tiki Roundtable Meeting
5)  20 Jun 2024 14:00 GMT-0000
Tiki Roundtable Meeting
6)  18 Jul 2024 14:00 GMT-0000
Tiki Roundtable Meeting
7)  15 Aug 2024 14:00 GMT-0000
Tiki Roundtable Meeting
8)  19 Sep 2024 14:00 GMT-0000
Tiki Roundtable Meeting
9) 
Tiki birthday
10)  17 Oct 2024 14:00 GMT-0000
Tiki Roundtable Meeting