PhpLayersDev

Robust fix for PML in Tiki ?

A permanent fix would require some major work to Tiki. The page builder needs to be re-engineered to build the HTML body first (into a buffer), keeping track of usage of things like phplayers, then once the body is done, prepare the HTML header (with only the appropriate includes) and prepend to the buffer. Finally, send the HTTP headers followed by HTTP body (from the buffer). This approach has a number of other benefits:

Possible to calculate the content-length and content-md5 and include those HTTP headers.
Might make some of the caching algorithms simpler
If #2 is true, once cached, sending HTTP HEAD responses is much easier
If #2 is true, once cached, sending HTTP caching headers is possible

(i'm not usre what's this about and if it's really needed still) luci

Notes

[+]

Discussion on IRC about the previous JS bug

mdavey where did you get to with numl?
mdavey (brb)
marclaporte I duplicated the bug on several sites
marclaporte both with IE & Firefox
marclaporte not sure what triggers it
mdavey pls. show me how to experience the bug 😉
marclaporte you have IE?
mdavey yes, v6 and firefox v1
mdavey (and mozilla v1.6)
mdavey IE and firefox are on Windows, Mozilla on Solaris.
mdavey hmm. numl is defined in the bit of script that norally gets included in the page when phplayers are active, around line 150 for tiki-index_raw.php
mdavey shutdown() is defined in layersmenu.js, which is included at laround line 50
mdavey is this very intermittent, or fairly reproducable once it happens ?
mdavey if the former, perhaps it is just another symptom of the cache / race condition bug that affects templates / menus / languages / themes and so on - where bits of the page fail to refresh correctly immediately after a major change to one of those things - and need a manual browser refresh to draw correctly?
mdavey (trackers) List trackers says there are 17 items in the features tracker, but I see an empty tracker. Permissions problem?
marclaporte try http://tikiwiki.org/tiki-irc_logs.php?find=&focus=20050212&action=display
mdavey (http://...) what am I looking for there?
marclaporte a js error popup
marclaporte you would know if it affected you
mdavey interesting. I don't think anything on that page is actually calling shutdown(), so the javascript checker is simply pre-parsing the javascript and saying that numl is undefined.
mdavey so, wrapping the import statement on line 50 with an if (phpmenus) then .... /if
mdavey .../should do the trick
mdavey an alternative would be to move everything out og ./lib/phplayers/libjs/layersmenu.js into the file that is inlined
mdavey *of
marclaporte it seems to happen more when I surf with many windows
mdavey (happen more) hmm.
mdavey (simple fix) lets see if I can find where the stuff is inclued
mdavey header is done by LayersMenu->MakeHeader() - searching for where that is called from
mdavey okay, printHeaders() is called from function smarty_function_phplayers() in lib/smarty_tiki/function.phplayers.php
mdavey I can't think of a way to tell while printing the HTTP headers, that we will be using {phplayers id=xx} somewhere in the body.