Loading...
 

Tikiwiki-devel (mailman list mirror)


Tiki15/trunk Newsletter 'difference' from Tiki12 - Zend framework change consequence ??

posts: 829 United Kingdom

Hi - I should have spotted this before but during my current Newsletter
testing of some commits I've just made in Tiki15 I've just realised that all
the emails being sent using Newsletter in Tiki15 also have the message as an
attachment. This does not seem to be anything to do with what I've recently
done since trunk shows the same behaviour and my recent changes have not yet
been merged in trunk.



Having the complete message repeated as an attachment does seem quite
unnecessary and this does not happen in Tiki12 - so I wonder whether it is a
consequence of all the changes made when the Zend framework was upgraded??



I've had a look at the code but I can't figure out why it is happening -
hope someone else can



Cheers



geoff












-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7497 / Virus Database: 4542/11860 - Release Date: 03/21/16

posts: 1218 Ireland

Hi Geoff,

if you can provide more details and samples I can try to have a look, when
the migration was done all care was taken to try to keep compatible with
the zf1 version, but is always hard :-)

Ricardo

On Mon, Mar 21, 2016 at 9:48 PM, Geoff - Enmore Services <
geoff at enmoreservices.com> wrote:

> Hi – I should have spotted this before but during my current Newsletter
> testing of some commits I've just made in Tiki15 I've just realised that
> all the emails being sent using Newsletter in Tiki15 also have the message
> as an attachment. This does not seem to be anything to do with what I've
> recently done since trunk shows the same behaviour and my recent changes
> have not yet been merged in trunk.
>
>
>
> Having the complete message repeated as an attachment does seem quite
> unnecessary and this does not happen in Tiki12 – so I wonder whether it is
> a consequence of all the changes made when the Zend framework was upgraded??
>
>
>
> I've had a look at the code but I can't figure out why it is happening –
> hope someone else can
>
>
>
> Cheers
>
>
>
> geoff
>
>
>
>
>
>
>
>
>
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2016.0.7497 / Virus Database: 4542/11860 - Release Date: 03/21/16
>
>
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 829 United Kingdom

Hi Ricardo – many thanks!



I have attached two example Newsletter emails sent from the latest versions of Tiki15 and Tiki12 (r58051) ie with my recent replyto fixes.



Both were sent in an identical way but as you will see the Tiki15 email has been 'constructed' differently – which is what made me suspect the zf upgrade – but I could easily be wrong about this.



Another thing I've just spotted that may be relevant, is that the Tiki12 email correctly contains the AVG virus check text and I could view the source which I have also attached.



But in the Tiki15 email the AVG text is missing? And I haven't found a way (with Outlook at least) to view the source.



Hope all this helps you spot why they are different



Thanks again



geoff







From: Ricardo Melo mailto:rjsmelo@gmail.com
Sent: 21 March 2016 23:00
To: Tiki developers <tikiwiki-devel@lists.sourceforge.net>
Subject: Re: Tiki-devel Tiki15/trunk Newsletter 'difference' from Tiki12 - Zend framework change consequence ??



Hi Geoff,



if you can provide more details and samples I can try to have a look, when the migration was done all care was taken to try to keep compatible with the zf1 version, but is always hard :-)



Ricardo



On Mon, Mar 21, 2016 at 9:48 PM, Geoff - Enmore Services <geoff@enmoreservices.com <mailto:geoff@enmoreservices.com> > wrote:

Hi – I should have spotted this before but during my current Newsletter testing of some commits I've just made in Tiki15 I've just realised that all the emails being sent using Newsletter in Tiki15 also have the message as an attachment. This does not seem to be anything to do with what I've recently done since trunk shows the same behaviour and my recent changes have not yet been merged in trunk.



Having the complete message repeated as an attachment does seem quite unnecessary and this does not happen in Tiki12 – so I wonder whether it is a consequence of all the changes made when the Zend framework was upgraded??



I've had a look at the code but I can't figure out why it is happening – hope someone else can



Cheers



geoff









No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 2016.0.7497 / Virus Database: 4542/11860 - Release Date: 03/21/16


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351 <http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140> &iu=/4140
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net <mailto:TikiWiki-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


posts: 829 United Kingdom

Hi Ricardo – one more thing I've just seen when checking the email headers

- For Tiki12: the X-Tiki header is simply set to 'yes', but

- For the Tiki15 email, the X-Tiki header is set as ?UTF-8?Q?yes?=



I'm not sure whether this is significant to the overall question about the difference in 'construct' between Tiki12 and Tiki15, but if anyone is using X-headers as part of some marketing/tracking campaign I think they should be set in a consistent way



Looking at the code this header seems to be set in function tiki_get_basic_mail – which is in maillib.php – and it is done differently in Tiki12 vs Tiki15?



Ie Tiki12:

$mail->addHeader('X-Tiki', 'yes');



And Tiki15:

$mail->getHeaders()->addHeaderLine('X-Tiki', 'yes');



Cheers



Geoff



PS – thinking about this, being able to set a specific X-Tiki header might be a useful new feature if you are using Newsletter as a marketing tool !! I might take a look at that :-)





From: Geoff - Enmore Services mailto:geoff@enmoreservices.com
Sent: 21 March 2016 23:39
To: 'Tiki developers' <tikiwiki-devel@lists.sourceforge.net>
Subject: RE: Tiki-devel Tiki15/trunk Newsletter 'difference' from Tiki12 - Zend framework change consequence ??



Hi Ricardo – many thanks!



I have attached two example Newsletter emails sent from the latest versions of Tiki15 and Tiki12 (r58051) ie with my recent replyto fixes.



Both were sent in an identical way but as you will see the Tiki15 email has been 'constructed' differently – which is what made me suspect the zf upgrade – but I could easily be wrong about this.



Another thing I've just spotted that may be relevant, is that the Tiki12 email correctly contains the AVG virus check text and I could view the source which I have also attached.



But in the Tiki15 email the AVG text is missing? And I haven't found a way (with Outlook at least) to view the source.



Hope all this helps you spot why they are different



Thanks again



geoff







From: Ricardo Melo mailto:rjsmelo@gmail.com
Sent: 21 March 2016 23:00
To: Tiki developers <tikiwiki-devel@lists.sourceforge.net <mailto:tikiwiki-devel@lists.sourceforge.net> >
Subject: Re: Tiki-devel Tiki15/trunk Newsletter 'difference' from Tiki12 - Zend framework change consequence ??



Hi Geoff,



if you can provide more details and samples I can try to have a look, when the migration was done all care was taken to try to keep compatible with the zf1 version, but is always hard :-)



Ricardo



On Mon, Mar 21, 2016 at 9:48 PM, Geoff - Enmore Services <geoff@enmoreservices.com <mailto:geoff@enmoreservices.com> > wrote:

Hi – I should have spotted this before but during my current Newsletter testing of some commits I've just made in Tiki15 I've just realised that all the emails being sent using Newsletter in Tiki15 also have the message as an attachment. This does not seem to be anything to do with what I've recently done since trunk shows the same behaviour and my recent changes have not yet been merged in trunk.



Having the complete message repeated as an attachment does seem quite unnecessary and this does not happen in Tiki12 – so I wonder whether it is a consequence of all the changes made when the Zend framework was upgraded??



I've had a look at the code but I can't figure out why it is happening – hope someone else can



Cheers



geoff









No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 2016.0.7497 / Virus Database: 4542/11860 - Release Date: 03/21/16



------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351 <http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140> &iu=/4140
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net <mailto:TikiWiki-devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel






-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7497 / Virus Database: 4542/11860 - Release Date: 03/21/16


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.