Loading...
 

Tikiwiki-devel (mailman list mirror)


Fwd: Tiki trunk: file galleries upload by drag'n'drop broken

Hi Oliver,

I have added null check before passing values in mentioned lines, please
update revision 59192 and confirm if its working fine for you now.

Regards

Amna Bilal

Chief Technology Officer
Genex Business Solutions
http://www.genexbs.com | http://www.marts.pk | http://www.iLahore.com


On Thu, Jul 14, 2016 at 11:54 PM, Amna Usman <amna@genexbs.com> wrote:

> I will check and fix it ASAP
> On Jul 14, 2016 11:49 PM, "Jonny Bradley" <jonny@tiki.org> wrote:
>
>> Hi Amna
>>
>> Are you on this mailing list? Would be a good idea to join I think.
>>
>> Meanwhile, it seems file uploading is broken in trunk and presumably this
>> is connected to the resizing work you were doing there - could you have a
>> look at this one please?
>>
>> Thanks,
>>
>> jonny
>>
>>
>> Begin forwarded message:
>>
>> *From:* Oliver Hertel <rom@readonly.de>
>> *Date:* 14 July 2016 at 19:40:16 BST
>> *To:* Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>> *Subject:* *Re: Tiki-devel Tiki trunk: file galleries upload by
>> drag'n'drop broken*
>> *Reply-To:* Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>>
>> Hello,
>>
>> drag'n'drop upload is broken. If you drop a file into the grey square
>> now, all you see is "Processing..." and that's it.
>>
>>
>> Found the problem.
>>
>> line 54: imageMaxWidth: $("#image_max_size_x").val(),
>> line 55: imageMaxHeight: $("#image_max_size_y").val(),
>>
>> As soon as I remove these two NEW lines from
>> lib/jquery_tiki/tiki-jquery_upload.js again, file uploads are back up
>> working.
>>
>> Can anyone fix this? I don't know how to fix it myself besides removing
>> the lines.
>>
>> Thanks!
>>
>> Oliver
>>
>>
>>
>> ------------------------------------------------------------------------------
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols
>> are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning
>> reports.http://sdm.link/zohodev2dev
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 9292 Germany

Hello Amna,

Thursday, July 14, 2016, 9:25:30 PM, you wrote:

> I have added null check before passing values in mentioned lines,
> please update revision 59192 and confirm if its working fine for you now.

I see the change, but still stalling, nothing happening after dropping a file onto the panel.
You sure it should be '' by default, not some numerical value?

I tried setting your values

val var_x=5000;
val var_y=5000;

didn't help. But when I edit the other two lines:

imageMaxWidth: 5000,
imageMaxHeight: 5000,

then uploads work... BUT: It crops the images to a square of same height and width; even when they are smaller than 5000 in height, the top gets cut off. >.<
There must be another bug with that.

Cheers,
Oliver


> Regards

> Amna Bilal

> Chief Technology Officer 
> Genex Business Solutions
> http://www.genexbs.com  | http://www.marts.pk | http://www.iLahore.com 

>

> On Thu, Jul 14, 2016 at 11:54 PM, Amna Usman <amna@genexbs.com> wrote:

> I will check and fix it ASAP

>
> On Jul 14, 2016 11:49 PM, "Jonny Bradley" <jonny@tiki.org> wrote:

> Hi Amna


> Are you on this mailing list? Would be a good idea to join I think. 


> Meanwhile, it seems file uploading is broken in trunk and
> presumably this is connected to the resizing work you were doing
> there - could you have a look at this one please?


> Thanks,

> jonny



> Begin forwarded message:


> From: Oliver Hertel <rom@readonly.de>
> Date: 14 July 2016 at 19:40:16 BST
> To: Tiki developers <tikiwiki-devel@lists.sourceforge.net>
> Subject: Re: Tiki-devel Tiki trunk: file galleries upload by drag'n'drop broken
> Reply-To: Tiki developers <tikiwiki-devel@lists.sourceforge.net>



> Hello,


> drag'n'drop upload is broken. If you drop a file into the grey
> square now, all you see is "Processing..." and that's it.



> Found the problem.

> line 54:            imageMaxWidth: $("#image_max_size_x").val(),
> line 55:            imageMaxHeight: $("#image_max_size_y").val(),

> As soon as I remove these two NEW lines from
> lib/jquery_tiki/tiki-jquery_upload.js again, file uploads are back up working.

> Can anyone fix this? I don't know how to fix it myself besides removing the lines.

> Thanks!

> Oliver


> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity planning
> reports.http://sdm.link/zohodev2dev
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



>





------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Hi Oliver,

Updated on svn, please update to revision 59194, I can not reproduce
problem at my local setup and its working fine too on trunk website, so
need your confirmation if its really solved.

Thanks for your help.

Regards,

Amna Bilal

Chief Technology Officer
Genex Business Solutions
http://www.genexbs.com | http://www.marts.pk | http://www.iLahore.com


On Fri, Jul 15, 2016 at 1:02 AM, Oliver Hertel <rom@readonly.de> wrote:

> Hello Amna,
>
> Thursday, July 14, 2016, 9:25:30 PM, you wrote:
>
> > I have added null check before passing values in mentioned lines,
> > please update revision 59192 and confirm if its working fine for you now.
>
> I see the change, but still stalling, nothing happening after dropping a
> file onto the panel.
> You sure it should be '' by default, not some numerical value?
>
> I tried setting your values
>
> val var_x=5000;
> val var_y=5000;
>
> didn't help. But when I edit the other two lines:
>
> imageMaxWidth: 5000,
> imageMaxHeight: 5000,
>
> then uploads work... BUT: It crops the images to a square of same height
> and width; even when they are smaller than 5000 in height, the top gets cut
> off. >.<
> There must be another bug with that.
>
> Cheers,
> Oliver
>
>
> > Regards
>
> > Amna Bilal
>
> > Chief Technology Officer
> > Genex Business Solutions
> > http://www.genexbs.com | http://www.marts.pk | http://www.iLahore.com
>
> >
>
> > On Thu, Jul 14, 2016 at 11:54 PM, Amna Usman <amna@genexbs.com> wrote:
>
> > I will check and fix it ASAP
>
> >
> > On Jul 14, 2016 11:49 PM, "Jonny Bradley" <jonny@tiki.org> wrote:
>
> > Hi Amna
>
>
> > Are you on this mailing list? Would be a good idea to join I think.
>
>
> > Meanwhile, it seems file uploading is broken in trunk and
> > presumably this is connected to the resizing work you were doing
> > there - could you have a look at this one please?
>
>
> > Thanks,
>
> > jonny
>
>
>
> > Begin forwarded message:
>
>
> > From: Oliver Hertel <rom@readonly.de>
> > Date: 14 July 2016 at 19:40:16 BST
> > To: Tiki developers <tikiwiki-devel@lists.sourceforge.net>
> > Subject: Re: Tiki-devel Tiki trunk: file galleries upload by
> drag'n'drop broken
> > Reply-To: Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>
>
>
> > Hello,
>
>
> > drag'n'drop upload is broken. If you drop a file into the grey
> > square now, all you see is "Processing..." and that's it.
>
>
>
> > Found the problem.
>
> > line 54: imageMaxWidth: $("#image_max_size_x").val(),
> > line 55: imageMaxHeight: $("#image_max_size_y").val(),
>
> > As soon as I remove these two NEW lines from
> > lib/jquery_tiki/tiki-jquery_upload.js again, file uploads are back up
> working.
>
> > Can anyone fix this? I don't know how to fix it myself besides removing
> the lines.
>
> > Thanks!
>
> > Oliver
>
>
> >
> ------------------------------------------------------------------------------
> > What NetFlow Analyzer can do for you? Monitors network bandwidth and
> traffic
> > patterns at an interface-level. Reveals which users, apps, and protocols
> are
> > consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> > J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning
> > reports.http://sdm.link/zohodev2dev
> > ___
> > TikiWiki-devel mailing list
> > TikiWiki-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> >

posts: 9292 Germany

Hello Amna,

Thursday, July 14, 2016, 11:36:01 PM, you wrote:

> Updated on svn, please update to revision 59194, I can not
> reproduce problem at my local setup and its working fine too on
> trunk website, so need your confirmation if its really solved. 

Fixed, and the cropping is gone, too. :-)

Thanks a lot!

Cheers,
Oliver



------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Thanks alot for help and confirmation Oliver :-)

Amna Bilal

Chief Technology Officer
Genex Business Solutions
http://www.genexbs.com | http://www.marts.pk | http://www.iLahore.com


On Fri, Jul 15, 2016 at 10:29 AM, Oliver Hertel <rom@readonly.de> wrote:

> Hello Amna,
>
> Thursday, July 14, 2016, 11:36:01 PM, you wrote:
>
> > Updated on svn, please update to revision 59194, I can not
> > reproduce problem at my local setup and its working fine too on
> > trunk website, so need your confirmation if its really solved.
>
> Fixed, and the cropping is gone, too. :-)
>
> Thanks a lot!
>
> Cheers,
> Oliver

posts: 126261

Hi Amna

Also confirming it works fine now for me too, many thanks for getting this fixed so quickly! :-)

jonny


> On 15 Jul 2016, at 07:05, Amna Usman <amna@genexbs.com> wrote:
>
> Thanks alot for help and confirmation Oliver :-)
>
> Amna Bilal
>
> Chief Technology Officer
> Genex Business Solutions
> http://www.genexbs.com | http://www.marts.pk | http://www.iLahore.com
>
>
> On Fri, Jul 15, 2016 at 10:29 AM, Oliver Hertel <rom@readonly.de> wrote:
>> Hello Amna,
>>
>> Thursday, July 14, 2016, 11:36:01 PM, you wrote:
>>
>> > Updated on svn, please update to revision 59194, I can not
>> > reproduce problem at my local setup and its working fine too on
>> > trunk website, so need your confirmation if its really solved.
>>
>> Fixed, and the cropping is gone, too. :-)
>>
>> Thanks a lot!
>>
>> Cheers,
>> Oliver
>>
>>
>


------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.