Loading...
 

Tikiwiki-devel (mailman list mirror)


img align=center problem

posts: 2695 United States

I originally posted in the Documentation forum, but solved the problem.

\{CODE()}{img align="center" src="img/wiki_up/tracker-dropdown1.png" }{CODE\}

SOLVED:
I removed the align="center" and voila the img appeared.

For page
https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field

This is legacy HTML code that apparently no longer works in modern browsers?
Should this be documented as a bug or something?

  • At least a note on the pages about images
    • https://doc.tiki.org/Wiki-Syntax+Images
    • https://doc.tiki.org/PluginImg

Should it's option have a warning saying it may not work with modern
browsers?
...?

WizarDave

posts: 1785 Catalan Countries

Added as a bug, thanks WizarDave for reporting

https://dev.tiki.org/item6073 - "LTS Regression: images not shown if
align=center as param (reproduced in doc.t.o)"

Imho, this deserves a better fix than just removing align=center? will
default behavior be aligning images, if that was the expected behavior
in pre-bootstrap tiki versions and sites out there that were designed in
the pre-bootstrap fashion?

If best fix is removing, than an sql upgrade script fix is needed, imho.

My 2 cents

Xavi

El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
> I originally posted in the Documentation forum, but solved the problem.
>

> \{CODE()\}
Image
\{CODE\}

>
> SOLVED:
> I removed the align="center" and voila the img appeared.
>
> For page
> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
>
> This is legacy HTML code that apparently no longer works in modern
> browsers?
> Should this be documented as a bug or something?
> *At least a note on the pages about images
> **https://doc.tiki.org/Wiki-Syntax+Images
> **https://doc.tiki.org/PluginImg
> Should it's option have a warning saying it may not work with modern
> browsers?
> ...?
>
> WizarDave
>
>
> ------------------------------------------------------------------------------
>
>
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 3563

Are you sure it is a bug? The align="center" seems to work fine on my
TIki 15, as well as the demo site:

https://demo.tiki.org/15x/ImageAlignCenter

-R


Rick Sapir
http://ricksapir.com
Twitter: @ricksapir

Creating content — Managing information


On 2016-08-03 10:27, Xavier de Pedro wrote:
> Added as a bug, thanks WizarDave for reporting
>
> https://dev.tiki.org/item6073 5 - "LTS Regression: images not
> shown if align=center as param (reproduced in doc.t.o)"
>
> Imho, this deserves a better fix than just removing align=center?
> will default behavior be aligning images, if that was the expected
> behavior in pre-bootstrap tiki versions and sites out there that were
> designed in the pre-bootstrap fashion?
>
> If best fix is removing, than an sql upgrade script fix is needed,
> imho.
>
> My 2 cents
>
> Xavi
>
> El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
>
>> I originally posted in the Documentation forum, but solved the
>> problem.
>>

>> \{CODE()\}
Image
\{CODE\}

>>
>> SOLVED:
>> I removed the align="center" and voila the img appeared.
>>
>> For page
>> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field 2
>>
>> This is legacy HTML code that apparently no longer works in modern
>> browsers?
>> Should this be documented as a bug or something?
>> *At least a note on the pages about images
>> **https://doc.tiki.org/Wiki-Syntax+Images 3
>> **https://doc.tiki.org/PluginImg 4
>> Should it's option have a warning saying it may not work with modern
>> browsers?
>> ...?
>>
>> WizarDave
>>
>>
> ------------------------------------------------------------------------------
>>
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel 1
>
>
>
> Links:
> ------
> 1 https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> 2 https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
> 3 https://doc.tiki.org/Wiki-Syntax+Images
> 4 https://doc.tiki.org/PluginImg
> 5 https://dev.tiki.org/item6073
>
> ------------------------------------------------------------------------------
>
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 1785 Catalan Countries

Hi Rick and thanks for your feedback.

Imho, it's a clear bug affecting to sites upgraded to latest versions
(such as doc.tiki.org) from earlier ones without boostrap, since the param

responsive="n"

that the example you provided in demo.t.o below had, was not written in
pages before bootstrap, and it's missing in sites upgraded.

Upgrades shouldn't make images automagically dissapear. If they
dissapear during the upgrade process, something is wrong that neds
fixing in the upgrade process, imho.

So Is the solution adding a responsive="n" to all plugin img calls
during the upgrade process if align="center" was a param in the plugin call?
If that is the case (I don't know), we would need some clever regexp or
similar to do that in an upgade php script, for instance, in the
installer/schema folder?


Xavi

El 03/08/16 a les 17:27, Rick Sapir ha escrit:
> Are you sure it is a bug? The align="center" seems to work fine on my
> TIki 15, as well as the demo site:
>
> https://demo.tiki.org/15x/ImageAlignCenter
>
> -R
>
> ---
> Rick Sapir
> http://ricksapir.com
> Twitter: @ricksapir
>
> Creating content — Managing information
>
>
> On 2016-08-03 10:27, Xavier de Pedro wrote:
>> Added as a bug, thanks WizarDave for reporting
>>
>> https://dev.tiki.org/item6073 5 - "LTS Regression: images not
>> shown if align=center as param (reproduced in doc.t.o)"
>>
>> Imho, this deserves a better fix than just removing align=center?
>> will default behavior be aligning images, if that was the expected
>> behavior in pre-bootstrap tiki versions and sites out there that were
>> designed in the pre-bootstrap fashion?
>>
>> If best fix is removing, than an sql upgrade script fix is needed,
>> imho.
>>
>> My 2 cents
>>
>> Xavi
>>
>> El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
>>
>>> I originally posted in the Documentation forum, but solved the
>>> problem.
>>>

>>> \{CODE()\}
Image
\{CODE\}

>>>
>>> SOLVED:
>>> I removed the align="center" and voila the img appeared.
>>>
>>> For page
>>> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field 2
>>>
>>> This is legacy HTML code that apparently no longer works in modern
>>> browsers?
>>> Should this be documented as a bug or something?
>>> *At least a note on the pages about images
>>> **https://doc.tiki.org/Wiki-Syntax+Images 3
>>> **https://doc.tiki.org/PluginImg 4
>>> Should it's option have a warning saying it may not work with modern
>>> browsers?
>>> ...?
>>>
>>> WizarDave
>>>
>>>
>> ------------------------------------------------------------------------------
>>
>>>
>>> ___
>>> TikiWiki-devel mailing list
>>> TikiWiki-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel 1
>>
>>
>>
>> Links:
>> ------
>> 1 https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> 2 https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
>> 3 https://doc.tiki.org/Wiki-Syntax+Images
>> 4 https://doc.tiki.org/PluginImg
>> 5 https://dev.tiki.org/item6073
>>
>> ------------------------------------------------------------------------------
>>
>>
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 126226 United Kingdom

Hi Xavi

Well deduced :-)

There's a pref now (14+ I think) to set that site-wide. It defaults to "y" I think currently because that was the default behaviour when it was introduced. Maybe should default to n (but still should work either way with centred images imho)

jonny

> On 5 Aug 2016, at 14:20, Xavier de Pedro <tiki@seeds4c.org> wrote:
>
> Hi Rick and thanks for your feedback.
>
> Imho, it's a clear bug affecting to sites upgraded to latest versions
> (such as doc.tiki.org) from earlier ones without boostrap, since the param
>
> responsive="n"
>
> that the example you provided in demo.t.o below had, was not written in
> pages before bootstrap, and it's missing in sites upgraded.
>
> Upgrades shouldn't make images automagically dissapear. If they
> dissapear during the upgrade process, something is wrong that neds
> fixing in the upgrade process, imho.
>
> So Is the solution adding a responsive="n" to all plugin img calls
> during the upgrade process if align="center" was a param in the plugin call?
> If that is the case (I don't know), we would need some clever regexp or
> similar to do that in an upgade php script, for instance, in the
> installer/schema folder?
>
>
> Xavi
>
> El 03/08/16 a les 17:27, Rick Sapir ha escrit:
>> Are you sure it is a bug? The align="center" seems to work fine on my
>> TIki 15, as well as the demo site:
>>
>> https://demo.tiki.org/15x/ImageAlignCenter
>>
>> -R
>>
>> ---
>> Rick Sapir
>> http://ricksapir.com
>> Twitter: @ricksapir
>>
>> Creating content — Managing information
>>
>>
>>> On 2016-08-03 10:27, Xavier de Pedro wrote:
>>> Added as a bug, thanks WizarDave for reporting
>>>
>>> https://dev.tiki.org/item6073 5 - "LTS Regression: images not
>>> shown if align=center as param (reproduced in doc.t.o)"
>>>
>>> Imho, this deserves a better fix than just removing align=center?
>>> will default behavior be aligning images, if that was the expected
>>> behavior in pre-bootstrap tiki versions and sites out there that were
>>> designed in the pre-bootstrap fashion?
>>>
>>> If best fix is removing, than an sql upgrade script fix is needed,
>>> imho.
>>>
>>> My 2 cents
>>>
>>> Xavi
>>>
>>> El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
>>>
>>>> I originally posted in the Documentation forum, but solved the
>>>> problem.
>>>>

>>>> \{CODE()\}
Image
\{CODE\}

>>>>
>>>> SOLVED:
>>>> I removed the align="center" and voila the img appeared.
>>>>
>>>> For page
>>>> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field 2
>>>>
>>>> This is legacy HTML code that apparently no longer works in modern
>>>> browsers?
>>>> Should this be documented as a bug or something?
>>>> *At least a note on the pages about images
>>>> **https://doc.tiki.org/Wiki-Syntax+Images 3
>>>> **https://doc.tiki.org/PluginImg 4
>>>> Should it's option have a warning saying it may not work with modern
>>>> browsers?
>>>> ...?
>>>>
>>>> WizarDave
>>> ------------------------------------------------------------------------------
>>>
>>>>
>>>> ___
>>>> TikiWiki-devel mailing list
>>>> TikiWiki-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel 1
>>>
>>>
>>>
>>> Links:
>>> ------
>>> 1 https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>> 2 https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
>>> 3 https://doc.tiki.org/Wiki-Syntax+Images
>>> 4 https://doc.tiki.org/PluginImg
>>> 5 https://dev.tiki.org/item6073
>>>
>>> ------------------------------------------------------------------------------
>>>
>>>
>>> ___
>>> TikiWiki-devel mailing list
>>> TikiWiki-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> ------------------------------------------------------------------------------
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 3563

I think the problem is much more. If you include a "desc" element (even
without the responsive) the align="center" works just fine:
https://demo.tiki.org/15x/ImageAlignCenter

But if you remove the "desc" element, the image disappears.

Me thinks something is broken somewhere.

-R


Rick Sapir
http://ricksapir.com
Twitter: @ricksapir

Creating content — Managing information


On 2016-08-05 09:26, Jonny Bradley wrote:
> Hi Xavi
>
> Well deduced :-)
>
> There's a pref now (14+ I think) to set that site-wide. It defaults to
> "y" I think currently because that was the default behaviour when it
> was introduced. Maybe should default to n (but still should work
> either way with centred images imho)
>
> jonny
>
>> On 5 Aug 2016, at 14:20, Xavier de Pedro <tiki@seeds4c.org> wrote:
>>
>> Hi Rick and thanks for your feedback.
>>
>> Imho, it's a clear bug affecting to sites upgraded to latest versions
>> (such as doc.tiki.org) from earlier ones without boostrap, since the
>> param
>>
>> responsive="n"
>>
>> that the example you provided in demo.t.o below had, was not written
>> in
>> pages before bootstrap, and it's missing in sites upgraded.
>>
>> Upgrades shouldn't make images automagically dissapear. If they
>> dissapear during the upgrade process, something is wrong that neds
>> fixing in the upgrade process, imho.
>>
>> So Is the solution adding a responsive="n" to all plugin img calls
>> during the upgrade process if align="center" was a param in the plugin
>> call?
>> If that is the case (I don't know), we would need some clever regexp
>> or
>> similar to do that in an upgade php script, for instance, in the
>> installer/schema folder?
>>
>>
>> Xavi
>>
>> El 03/08/16 a les 17:27, Rick Sapir ha escrit:
>>> Are you sure it is a bug? The align="center" seems to work fine on my
>>> TIki 15, as well as the demo site:
>>>
>>> https://demo.tiki.org/15x/ImageAlignCenter
>>>
>>> -R
>>>
>>> ---
>>> Rick Sapir
>>> http://ricksapir.com
>>> Twitter: @ricksapir
>>>
>>> Creating content — Managing information
>>>
>>>
>>>> On 2016-08-03 10:27, Xavier de Pedro wrote:
>>>> Added as a bug, thanks WizarDave for reporting
>>>>
>>>> https://dev.tiki.org/item6073 5 - "LTS Regression: images not
>>>> shown if align=center as param (reproduced in doc.t.o)"
>>>>
>>>> Imho, this deserves a better fix than just removing align=center?
>>>> will default behavior be aligning images, if that was the expected
>>>> behavior in pre-bootstrap tiki versions and sites out there that
>>>> were
>>>> designed in the pre-bootstrap fashion?
>>>>
>>>> If best fix is removing, than an sql upgrade script fix is needed,
>>>> imho.
>>>>
>>>> My 2 cents
>>>>
>>>> Xavi
>>>>
>>>> El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
>>>>
>>>>> I originally posted in the Documentation forum, but solved the
>>>>> problem.
>>>>>

>>>>> \{CODE()\}
Image
\{CODE\}

>>>>>
>>>>> SOLVED:
>>>>> I removed the align="center" and voila the img appeared.
>>>>>
>>>>> For page
>>>>> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field 2
>>>>>
>>>>> This is legacy HTML code that apparently no longer works in modern
>>>>> browsers?
>>>>> Should this be documented as a bug or something?
>>>>> *At least a note on the pages about images
>>>>> **https://doc.tiki.org/Wiki-Syntax+Images 3
>>>>> **https://doc.tiki.org/PluginImg 4
>>>>> Should it's option have a warning saying it may not work with
>>>>> modern
>>>>> browsers?
>>>>> ...?
>>>>>
>>>>> WizarDave
>>>> ------------------------------------------------------------------------------
>>>>
>>>>>
>>>>> ___
>>>>> TikiWiki-devel mailing list
>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel 1
>>>>
>>>>
>>>>
>>>> Links:
>>>> ------
>>>> 1 https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>> 2 https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
>>>> 3 https://doc.tiki.org/Wiki-Syntax+Images
>>>> 4 https://doc.tiki.org/PluginImg
>>>> 5 https://dev.tiki.org/item6073
>>>>
>>>> ------------------------------------------------------------------------------
>>>>
>>>>
>>>> ___
>>>> TikiWiki-devel mailing list
>>>> TikiWiki-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>>
>> ------------------------------------------------------------------------------
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
>
> ------------------------------------------------------------------------------
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

------------------------------------------------------------------------------
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 1785 Catalan Countries

Thanks jonny-on-vacation :-)

+1 to default to "no" in upgrades from before 14. How can we do that?


(btw, added the pref also in the upgrade wizard in r59377, so that human
"beans" like me can know about that when reading the "what's new"-like
info in that wizard).

Xavi

El 05/08/16 a les 15:26, Jonny Bradley ha escrit:
> Hi Xavi
>
> Well deduced :-)
>
> There's a pref now (14+ I think) to set that site-wide. It defaults to "y" I think currently because that was the default behaviour when it was introduced. Maybe should default to n (but still should work either way with centred images imho)
>
> jonny
>
>> On 5 Aug 2016, at 14:20, Xavier de Pedro <tiki@seeds4c.org> wrote:
>>
>> Hi Rick and thanks for your feedback.
>>
>> Imho, it's a clear bug affecting to sites upgraded to latest versions
>> (such as doc.tiki.org) from earlier ones without boostrap, since the param
>>
>> responsive="n"
>>
>> that the example you provided in demo.t.o below had, was not written in
>> pages before bootstrap, and it's missing in sites upgraded.
>>
>> Upgrades shouldn't make images automagically dissapear. If they
>> dissapear during the upgrade process, something is wrong that neds
>> fixing in the upgrade process, imho.
>>
>> So Is the solution adding a responsive="n" to all plugin img calls
>> during the upgrade process if align="center" was a param in the plugin call?
>> If that is the case (I don't know), we would need some clever regexp or
>> similar to do that in an upgade php script, for instance, in the
>> installer/schema folder?
>>
>>
>> Xavi
>>
>> El 03/08/16 a les 17:27, Rick Sapir ha escrit:
>>> Are you sure it is a bug? The align="center" seems to work fine on my
>>> TIki 15, as well as the demo site:
>>>
>>> https://demo.tiki.org/15x/ImageAlignCenter
>>>
>>> -R
>>>
>>> ---
>>> Rick Sapir
>>> http://ricksapir.com
>>> Twitter: @ricksapir
>>>
>>> Creating content — Managing information
>>>
>>>
>>>> On 2016-08-03 10:27, Xavier de Pedro wrote:
>>>> Added as a bug, thanks WizarDave for reporting
>>>>
>>>> https://dev.tiki.org/item6073 5 - "LTS Regression: images not
>>>> shown if align=center as param (reproduced in doc.t.o)"
>>>>
>>>> Imho, this deserves a better fix than just removing align=center?
>>>> will default behavior be aligning images, if that was the expected
>>>> behavior in pre-bootstrap tiki versions and sites out there that were
>>>> designed in the pre-bootstrap fashion?
>>>>
>>>> If best fix is removing, than an sql upgrade script fix is needed,
>>>> imho.
>>>>
>>>> My 2 cents
>>>>
>>>> Xavi
>>>>
>>>> El 03/08/16 a les 16:13, WizarDave Akins ha escrit:
>>>>
>>>>> I originally posted in the Documentation forum, but solved the
>>>>> problem.
>>>>>

>>>>> \{CODE()\}
Image
\{CODE\}

>>>>>
>>>>> SOLVED:
>>>>> I removed the align="center" and voila the img appeared.
>>>>>
>>>>> For page
>>>>> https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field 2
>>>>>
>>>>> This is legacy HTML code that apparently no longer works in modern
>>>>> browsers?
>>>>> Should this be documented as a bug or something?
>>>>> *At least a note on the pages about images
>>>>> **https://doc.tiki.org/Wiki-Syntax+Images 3
>>>>> **https://doc.tiki.org/PluginImg 4
>>>>> Should it's option have a warning saying it may not work with modern
>>>>> browsers?
>>>>> ...?
>>>>>
>>>>> WizarDave
>>>> ------------------------------------------------------------------------------
>>>>
>>>>> ___
>>>>> TikiWiki-devel mailing list
>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel 1
>>>>
>>>>
>>>> Links:
>>>> ------
>>>> 1 https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>> 2 https://doc.tiki.org/Drop+Down+-+Radio+Tracker+Field
>>>> 3 https://doc.tiki.org/Wiki-Syntax+Images
>>>> 4 https://doc.tiki.org/PluginImg
>>>> 5 https://dev.tiki.org/item6073
>>>>
>>>> ------------------------------------------------------------------------------
>>>>
>>>>
>>>> ___
>>>> TikiWiki-devel mailing list
>>>> TikiWiki-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>> ------------------------------------------------------------------------------
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
> ------------------------------------------------------------------------------
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


------------------------------------------------------------------------------
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.