Loading...
 

Tikiwiki-devel (mailman list mirror)


You are viewing a reply to Using tags for commits  

Using tags for commits

posts: 126106 United Kingdom

Hi Aris

Just catching up with the backlog of draft stub emails ;)

No i don't think we need another rule for this, it's really not as important as the code, and yes the docs have become messy and confusing, it's the wiki-way ;) Please do help to tidy them up of you can see a way to, personally i tend to use the TAG for the type of commit and then put a second "feature" or "area" or "project" label for my own use so i can group similar commits together for backporting etc.

But that's just me :-)

Thanks, how's the auth stuff going?

jonny





> On 8 Apr 2018, at 13:45, Arijus Bernotas via TikiWiki-devel <tikiwiki-devel@lists.sourceforge.net> wrote:
>
> Hi devs,
>
> I am posting this to all not because I want to argue about the usefulness of tags but to prevent the need of this kind of emails and maybe to bring more clarity to all...
>
> 1. To my defence - In the 3 rules I have agreed to abide the obligatory usage of tags was not mentioned...
>
> Should it be rule No 4, then?
>
> 2. Also, in the
>
> https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
>
> I can't see anything related to obligatory except saying: "The following tags can be used to distinguish changes:"
>
> 3. Also, there is an article https://dev.tiki.org/Commit-Tags which also adds to the confusion.
>
>
> With respect,
>
> Aris
>
>
>
> On 06/04/18 19:42, Cloutier, Philippe (DGARI-Consultant) wrote:
>> Thanks Torsten,
>>
>>> -----Message d'origine-----
>>> De : Torsten Fabricius mailto:torsten@tiki.org
>>> Envoyé : 6 avril 2018 14:18
>>> À : Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>>> Objet : Tiki-devel Using tags for commits
>>>
>>> Hi kroky6 and aris002,
>>>
>>> I just have seen, that you did not use tags at your last commits:
>>> r65847 , r65832
>>>
>>> https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
>>>
>>> Afaik using tags is recommended or obligatory for Tiki devs.
>>
>> Using tags is good but not mandatory.
>>
>> I suggest to address such mails to the involved developers only, Cc-ing the commits list.
>>
>>> Just saying.
>>>
>>> Best regards,
>>> Torsten
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Hi Aris,

It seems everybody has slighly different opinions on what tags are for
anyway. :-)

My view about tags is, they help communicate the purpose of a commit to
other developpers who want to review commits.
Also, only commits with tags get to be listed in the changelog.txt file
which is used for figuring out what's new in Tiki between version for
people who update the release notes.

So, I do commit without tags for commits which have no effect and which do
not deserve to be archived in changelog.txt
Such as a minor typo in the french language file or a copyright notice
update (which we decided we would stop doing, yay!)

Cheers,
Jean-Marc

On Sun, Apr 15, 2018 at 8:44 AM, Jonny Bradley <jonny@tiki.org> wrote:

> Hi Aris
>
> Just catching up with the backlog of draft stub emails ;)
>
> No i don't think we need another rule for this, it's really not as
> important as the code, and yes the docs have become messy and confusing,
> it's the wiki-way ;) Please do help to tidy them up of you can see a way
> to, personally i tend to use the TAG for the type of commit and then put
> a second "feature" or "area" or "project" label for my own use so i can
> group similar commits together for backporting etc.
>
> But that's just me :-)
>
> Thanks, how's the auth stuff going?
>
> jonny
>
>
>
>
>
> > On 8 Apr 2018, at 13:45, Arijus Bernotas via TikiWiki-devel <
> tikiwiki-devel at lists.sourceforge.net> wrote:
> >
> > Hi devs,
> >
> > I am posting this to all not because I want to argue about the
> usefulness of tags but to prevent the need of this kind of emails and maybe
> to bring more clarity to all...
> >
> > 1. To my defence - In the 3 rules I have agreed to abide the obligatory
> usage of tags was not mentioned...
> >
> > Should it be rule No 4, then?
> >
> > 2. Also, in the
> >
> > https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
> >
> > I can't see anything related to obligatory except saying: "The following
> tags can be used to distinguish changes:"
> >
> > 3. Also, there is an article https://dev.tiki.org/Commit-Tags which
> also adds to the confusion.
> >
> >
> > With respect,
> >
> > Aris
> >
> >
> >
> > On 06/04/18 19:42, Cloutier, Philippe (DGARI-Consultant) wrote:
> >> Thanks Torsten,
> >>
> >>> -----Message d'origine-----
> >>> De : Torsten Fabricius mailto:torsten@tiki.org
> >>> Envoyé : 6 avril 2018 14:18
> >>> À : Tiki developers <tikiwiki-devel@lists.sourceforge.net>
> >>> Objet : Tiki-devel Using tags for commits
> >>>
> >>> Hi kroky6 and aris002,
> >>>
> >>> I just have seen, that you did not use tags at your last commits:
> >>> r65847 , r65832
> >>>
> >>> https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
> >>>
> >>> Afaik using tags is recommended or obligatory for Tiki devs.
> >>
> >> Using tags is good but not mandatory.
> >>
> >> I suggest to address such mails to the involved developers only, Cc-ing
> the commits list.
> >>
> >>> Just saying.
> >>>
> >>> Best regards,
> >>> Torsten
> >> ------------------------------------------------------------
> ------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> TikiWiki-devel mailing list
> >> TikiWiki-devel at lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > TikiWiki-devel mailing list
> > TikiWiki-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Hi,

>De : Jean-Marc Libs mailto:jeanmarc.libs@gmail.com
>Envoyé : 17 avril 2018 14:01
>À : Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>Objet : Re: Tiki-devel Using tags for commits
>
>...
>Also, only commits with tags get to be listed in the changelog.txt file which is used for figuring out what's new in Tiki between version for people who update the release notes.
>So, I do commit without tags for commits which have no effect and which do not deserve to be archived in changelog.txt

Commits without functional effects should (at least generally) be tagged REF. I think it is correct that the changelog used to be generated that way, but I this that was wrong. The purpose of commits without tags should simply be considered other or unspecified.

>...
>Cheers,
>Jean-Marc
>
>>On Sun, Apr 15, 2018 at 8:44 AM, Jonny Bradley <jonny@tiki.org> wrote:
>>Hi Aris
>>
>>Just catching up with the backlog of draft stub emails ;)
>>
>>No i don't think we need another rule for this, it's really not as important as the code, and yes the docs have become messy and confusing, it's the wiki-way ;) Please do help to tidy them up of you can see a way to, personally i tend to use the TAG for the type of commit and then put a second "feature" or "area" or "project" label for my own use so i can group similar commits together for backporting etc.
>>
>>But that's just me :-)
>>
>>Thanks, how's the auth stuff going?
>>
>>jonny
>>
>>
>>
>>
>>
>>> On 8 Apr 2018, at 13:45, Arijus Bernotas via TikiWiki-devel <tikiwiki-devel@lists.sourceforge.net> wrote:
>>>
>>> Hi devs,
>>>
>>> I am posting this to all not because I want to argue about the usefulness of tags but to prevent the need of this kind of emails and maybe to bring more clarity to all...
>>>
>>> 1. To my defence - In the 3 rules I have agreed to abide the obligatory usage of tags was not mentioned...
>>>
>>> Should it be rule No 4, then?
>>>
>>> 2. Also, in the
>>>
>>> https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
>>>
>>> I can't see anything related to obligatory except saying: "The following tags can be used to distinguish changes:"
>>>
>>> 3. Also, there is an article https://dev.tiki.org/Commit-Tags which also adds to the confusion.
>>>
>>>
>>> With respect,
>>>
>>> Aris
>>>
>>>
>>>
>>> On 06/04/18 19:42, Cloutier, Philippe (DGARI-Consultant) wrote:
>>>> Thanks Torsten,
>>>>
>>>>> -----Message d'origine-----
>>>>> De : Torsten Fabricius mailto:torsten@tiki.org
>>>>> Envoyé : 6 avril 2018 14:18
>>>>> À : Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>>>>> Objet : Tiki-devel Using tags for commits
>>>>>
>>>>> Hi kroky6 and aris002,
>>>>>
>>>>> I just have seen, that you did not use tags at your last commits:
>>>>> r65847 , r65832
>>>>>
>>>>> https://dev.tiki.org/Commit-Code#Step_6:_Commit_Your_Changes
>>>>>
>>>>> Afaik using tags is recommended or obligatory for Tiki devs.
>>>>
>>>> Using tags is good but not mandatory.
>>>>
>>>> I suggest to address such mails to the involved developers only, Cc-ing the commits list.
>>>>
>>>>> Just saying.
>>>>>
>>>>> Best regards,
>>>>> Torsten
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Hi, Jonny and all!

Progress with auth was good but not as good as I expected with
hybridauth... It appears drupal and others also dropped hybridauth in
favour of https://github.com/thephpleague/oauth2-client

I have also done twitter auth on one of my tiki dev sites (Jonny and
Bernard have that link) but with https://github.com/abraham/twitteroauth

All these libraries have their +'s and -'s.

I have one plan to join the best parts from them and make my/our own
variant.
I have found that on the tiki side ( /lib folder ) we will need to
change/remove/clean some authentication stuff and some in .tpl files.

But now I am in Germany this week and will be very busy moving to
Lithuania in the next 2 weeks, so I will resume this work in May.

Aris

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 166

Thanks for the update Aris!


On Wednesday, April 18, 2018, Arijus Bernotas via TikiWiki-devel <
tikiwiki-devel at lists.sourceforge.net> wrote:

> Hi, Jonny and all!
>
> Progress with auth was good but not as good as I expected with
> hybridauth... It appears drupal and others also dropped hybridauth in
> favour of https://github.com/thephpleague/oauth2-client
>
> I have also done twitter auth on one of my tiki dev sites (Jonny and
> Bernard have that link) but with https://github.com/abraham/twitteroauth
>
> All these libraries have their +'s and -'s.
>
> I have one plan to join the best parts from them and make my/our own
> variant.
> I have found that on the tiki side ( /lib folder ) we will need to
> change/remove/clean some authentication stuff and some in .tpl files.
>
> But now I am in Germany this week and will be very busy moving to
> Lithuania in the next 2 weeks, so I will resume this work in May.
>
> Aris
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>


--
Marc Laporte

http://WikiSuite.org
http://PluginProblems.com
http://Avan.Tech

posts: 126106 United Kingdom

Hi Aris and all social media login fans!

I think the thephpleague/oauth2-client sounds like the strongest one, but have no personal experience of it, i'm not sure about us (you ;) doing a fork/mix of these, wouldn't that one do what we need? Like Highlander i think... :-)

Good luck with them move, i'm also going to be mostly offline/travelling/jet-lagged for a week or so, back to normal (IRC etc) soon!

jb







> On 19 Apr 2018, at 07:13, Marc Laporte <marc@marclaporte.com> wrote:
>
> Thanks for the update Aris!
>
>
> On Wednesday, April 18, 2018, Arijus Bernotas via TikiWiki-devel <tikiwiki-devel@lists.sourceforge.net> wrote:
>> Hi, Jonny and all!
>>
>> Progress with auth was good but not as good as I expected with hybridauth... It appears drupal and others also dropped hybridauth in favour of https://github.com/thephpleague/oauth2-client
>>
>> I have also done twitter auth on one of my tiki dev sites (Jonny and Bernard have that link) but with https://github.com/abraham/twitteroauth
>>
>> All these libraries have their +'s and -'s.
>>
>> I have one plan to join the best parts from them and make my/our own variant.
>> I have found that on the tiki side ( /lib folder ) we will need to change/remove/clean some authentication stuff and some in .tpl files.
>>
>> But now I am in Germany this week and will be very busy moving to Lithuania in the next 2 weeks, so I will resume this work in May.
>>
>> Aris
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
> —
> Marc Laporte
>
> http://WikiSuite.org
> http://PluginProblems.com
> http://Avan.Tech
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.