Loading...
 

Tikiwiki-devel (mailman list mirror)


PluginPageLayout Merge with PluginAppFrame

Thanks for the feedback Luci and Jonny,

@Luci, I agree with your suggestions about simple parameters names. Will be
easier for manual input.

@Jonny: Will investigate it further, how to load custom Tpl via wiki
plugin, instead of main Tpl, any reference plugin? I have checked AppFrame,
its also using CSS/JS to hide elements.

Thanks for having look.

Regards
Amna Bilal


On Tue, Jul 10, 2018 at 6:32 PM Jonny Bradley <jonny@tiki.org> wrote:

>
> > On 10 Jul 2018, at 14:28, Jonny Bradley <jonny@tiki.org> wrote:
> >
> > Hi Anna
>
> Sorry Amna, it autocorrected! :P
>
> > and all
> >
> > Sorry i haven't had time to really investigate this but i think i agree
> that it might over complicate things to merge the two plugins now - the
> idea of appframe is that it's deliberately minimal in terms of parameters
> (like the list plugin), and you use sub-plugins to create your "app"
> background and features... so i don't think adding an arbitrary fgalId
> param for instance, to do a hard-coded slideshow background would be a good
> idea...
> >
> > One thought though, instead of using css to hide elements you don't
> want, why not use a different page layout template, so make a new version
> of templates/layouts/basic/layout_view.tpl for instance so if you're hiding
> the module zones it doesn't need to render them all and then hide them.
> Maybe it could be templates/layouts/internal/pagelayout_view.tpl or
> something?
> >
> > Will try and get back to you with more another day...
> >
> > Thanks :-)
> >
> > jonny
> >
> >
> >
> >
> >> On 10 Jul 2018, at 14:13, luciash <luci@tiki.org> wrote:
> >>
> >> Hi Amna,
> >>
> >> thank you! I am not sure if merge or not to merge (if merging would not
> make the two too complex and keep the old one still working on upgrades)
> but I have some feedback on the new plugin:
> >>
> >> Why not to make it simpler for users/developers?
> >>
> >> What about changing the params to:
> >>
> >> {pagelayout header="n" footer="n" leftcol="n" rightcol="n"
> fullwidth="y" width="70%" padding="3%" background="#000" contentbg="rgba(0,
> 0, 0, 0.8)" contentcolor="#fff" actions="n" fgalId="9"}
> >>
> >> And if you want to try the merge, perhaps merge the two plugins to
> different one first simply named plugin "Layout" (does it matter if it does
> not contain the word page or app)? So the syntax would be even simpler:
> >> {layout header="n" footer="n" leftcol="n" rightcol="n" fullwidth="y"
> width="70%" padding="3%" background="#000" contentbg="rgba(0, 0, 0, 0.8)"
> contentcolor="#fff" actions="n" fgalId="9"}
> >>
> >>
> >> HTH,
> >>
> >> luci
> >>
> >>
> >> On 10.07.2018 9:18, amna usman wrote:
> >>> Hi,
> >>>
> >>> Recently I have committed first version of pluginPageLayout in trunk,
> sample code to try out:
> >>>
> >>> {pagelayout pageHeader="n" pageFooter="n" pageLeftBar="n"
> pageRightBar="n" pageFullWidth="y" pageContentWidth="70%"
> pageContentPadding="3%" pageBackgroundColor="#000" contentBg="rgba(00, 00,
> 00, 0.8)" contentTextColor="#fff" pageActionButtons="n" fgalId="9"}
> >>>
> >>>
> >>>
> >>> And few demo links:
> >>> http://duedaily.com/trunk/tiki-index.php?page=PageLayout
> >>> http://duedaily.com/trunk/tiki-index.php?page=Login-Landing
> >>> http://duedaily.com/trunk/tiki-index.php?page=pageLayout-swiper
> >>>
> >>> Flicking issue in background images will be solved with preloading of
> images.
> >>>
> >>> Jonny pointed out this plugin is similar to PluginAppFrame, I have
> checked and here my findings:
> >>>
> >>> 1- AppFrame is placing a div over main body but its removing all page
> content.
> >>> 2- Keeping header and page action buttons.
> >>> 3- Also appFrame body content hides under action button bar (that
> needs to be fixed anyways)
> >>> 4- It basically giving blank canvas for user to fill in create page
> using body parameter of plugin.
> >>>
> >>> So we can:
> >>> 1- Either keep both separate (simple one pageLayout for simple hiding
> and backgrounds only) and appFrame for more complicated operations and
> advance users,
> >>> 2- Or can merge as Jonny suggested.
> >>>
> >>> For merge, additional options appFrame will have:
> >>> 1- Background colors
> >>> 2- File gallery slideshow
> >>> 3- Hide header and page action bars
> >>> 4- Use main body content if plugin body is empty, since its easier for
> users to compose page in editor rather than plugin body.
> >>>
> >>> Also my other concern was name of AppFrame that sounds more like
> application development rather than controlling page layout.
> >>>
> >>> Please vote if:
> >>>
> >>> 1- We should keep both plugins separate
> >>> 2- Or merge AppFrame and PluginPageLayout
> >>>
> >>>
> >>> Regards,
> >>> Amna Bilal
> >>>
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Check out the vibrant tech community on one of the world's most
> >>> engaging tech sites, Slashdot.org!
> >>> http://sdm.link/slashdot
> >>>
> >>>
> >>> ___
> >>> TikiWiki-devel mailing list
> >>>
> >>> TikiWiki-devel at lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >>
> >>
> ------------------------------------------------------------------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot_
> >> TikiWiki-devel mailing list
> >> TikiWiki-devel at lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
> >
> >
> ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > TikiWiki-devel mailing list
> > TikiWiki-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

posts: 126137 United Kingdom

Hi Amna

It's a good question as to whether a plugin in a page and change the top level layout tpl, i'll have a dig about - i'm looking for uses of the pref site_layout which is the one in look & feel you can use to set the main layout.

This is interesting, in lib/init/smarty.php:455 the current object is checked for a tiki.object.layout attribute and will use that as the site_layout pref if there is one (who knew!? ;)

This picks the dir inside templates/layouts where to look for tpls like layout_view.tpl and layout_edit.tpl... so, how about:

You make a new dir in templates/layouts called plugin_pagelayout (for instance) and fork a copy of templates/layouts/basic/layout_view.tpl, which i think is the simplest one, and add the tests for your plugin settings as to whether to render the module zones or not?

Not 100% sure how you would pass on those parameters, maybe with more attributes on the object (wiki page or whatever)? Would be ugly to use global smarty vars i think for this...

Anyway, does that give you something to start on? Ping me if you want to discuss it or work out a better way...

jonny




> On 10 Jul 2018, at 16:24, Amna Usman <amna@genexbs.com> wrote:
>
> Thanks for the feedback Luci and Jonny,
>
> @Luci, I agree with your suggestions about simple parameters names. Will be easier for manual input.
>
> @Jonny: Will investigate it further, how to load custom Tpl via wiki plugin, instead of main Tpl, any reference plugin? I have checked AppFrame, its also using CSS/JS to hide elements.
>
> Thanks for having look.
>
> Regards
> Amna Bilal
>
>
> On Tue, Jul 10, 2018 at 6:32 PM Jonny Bradley <jonny@tiki.org> wrote:
>>
>> > On 10 Jul 2018, at 14:28, Jonny Bradley <jonny@tiki.org> wrote:
>> >
>> > Hi Anna
>>
>> Sorry Amna, it autocorrected! :P
>>
>> > and all
>> >
>> > Sorry i haven't had time to really investigate this but i think i agree that it might over complicate things to merge the two plugins now - the idea of appframe is that it's deliberately minimal in terms of parameters (like the list plugin), and you use sub-plugins to create your "app" background and features... so i don't think adding an arbitrary fgalId param for instance, to do a hard-coded slideshow background would be a good idea...
>> >
>> > One thought though, instead of using css to hide elements you don't want, why not use a different page layout template, so make a new version of templates/layouts/basic/layout_view.tpl for instance so if you're hiding the module zones it doesn't need to render them all and then hide them. Maybe it could be templates/layouts/internal/pagelayout_view.tpl or something?
>> >
>> > Will try and get back to you with more another day...
>> >
>> > Thanks :-)
>> >
>> > jonny
>> >
>> >
>> >
>> >
>> >> On 10 Jul 2018, at 14:13, luciash <luci@tiki.org> wrote:
>> >>
>> >> Hi Amna,
>> >>
>> >> thank you! I am not sure if merge or not to merge (if merging would not make the two too complex and keep the old one still working on upgrades) but I have some feedback on the new plugin:
>> >>
>> >> Why not to make it simpler for users/developers?
>> >>
>> >> What about changing the params to:
>> >>
>> >> \{pagelayout header="n" footer="n" leftcol="n" rightcol="n" fullwidth="y" width="70%" padding="3%" background="#000" contentbg="rgba(0, 0, 0, 0.8)" contentcolor="#fff" actions="n" fgalId="9"\}
>> >>
>> >> And if you want to try the merge, perhaps merge the two plugins to different one first simply named plugin "Layout" (does it matter if it does not contain the word page or app)? So the syntax would be even simpler:
>> >> \{layout header="n" footer="n" leftcol="n" rightcol="n" fullwidth="y" width="70%" padding="3%" background="#000" contentbg="rgba(0, 0, 0, 0.8)" contentcolor="#fff" actions="n" fgalId="9"\}
>> >>
>> >>
>> >> HTH,
>> >>
>> >> luci
>> >>
>> >>
>> >> On 10.07.2018 9:18, amna usman wrote:
>> >>> Hi,
>> >>>
>> >>> Recently I have committed first version of pluginPageLayout in trunk, sample code to try out:
>> >>>
>> >>> \{pagelayout pageHeader="n" pageFooter="n" pageLeftBar="n" pageRightBar="n" pageFullWidth="y" pageContentWidth="70%" pageContentPadding="3%" pageBackgroundColor="#000" contentBg="rgba(00, 00, 00, 0.8)" contentTextColor="#fff" pageActionButtons="n" fgalId="9"\}
>> >>>
>> >>>
>> >>>
>> >>> And few demo links:
>> >>> http://duedaily.com/trunk/tiki-index.php?page=PageLayout
>> >>> http://duedaily.com/trunk/tiki-index.php?page=Login-Landing
>> >>> http://duedaily.com/trunk/tiki-index.php?page=pageLayout-swiper
>> >>>
>> >>> Flicking issue in background images will be solved with preloading of images.
>> >>>
>> >>> Jonny pointed out this plugin is similar to PluginAppFrame, I have checked and here my findings:
>> >>>
>> >>> 1- AppFrame is placing a div over main body but its removing all page content.
>> >>> 2- Keeping header and page action buttons.
>> >>> 3- Also appFrame body content hides under action button bar (that needs to be fixed anyways)
>> >>> 4- It basically giving blank canvas for user to fill in create page using body parameter of plugin.
>> >>>
>> >>> So we can:
>> >>> 1- Either keep both separate (simple one pageLayout for simple hiding and backgrounds only) and appFrame for more complicated operations and advance users,
>> >>> 2- Or can merge as Jonny suggested.
>> >>>
>> >>> For merge, additional options appFrame will have:
>> >>> 1- Background colors
>> >>> 2- File gallery slideshow
>> >>> 3- Hide header and page action bars
>> >>> 4- Use main body content if plugin body is empty, since its easier for users to compose page in editor rather than plugin body.
>> >>>
>> >>> Also my other concern was name of AppFrame that sounds more like application development rather than controlling page layout.
>> >>>
>> >>> Please vote if:
>> >>>
>> >>> 1- We should keep both plugins separate
>> >>> 2- Or merge AppFrame and PluginPageLayout
>> >>>
>> >>>
>> >>> Regards,
>> >>> Amna Bilal
>> >>>
>> >>>
>> >>>
>> >>> ------------------------------------------------------------------------------
>> >>> Check out the vibrant tech community on one of the world's most
>> >>> engaging tech sites, Slashdot.org!
>> >>> http://sdm.link/slashdot
>> >>>
>> >>>
>> >>> ___
>> >>> TikiWiki-devel mailing list
>> >>>
>> >>> TikiWiki-devel at lists.sourceforge.net
>> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> >>
>> >> ------------------------------------------------------------------------------
>> >> Check out the vibrant tech community on one of the world's most
>> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_
>> >> TikiWiki-devel mailing list
>> >> TikiWiki-devel at lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > ___
>> > TikiWiki-devel mailing list
>> > TikiWiki-devel at lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Thanks alot Jonny for input, having a look and will get back on it.

Regards
Amna Bilal


On Fri, Jul 13, 2018 at 3:06 PM Jonny Bradley <jonny@tiki.org> wrote:

> Hi Amna
>
> It's a good question as to whether a plugin in a page and change the top
> level layout tpl, i'll have a dig about - i'm looking for uses of the pref
> site_layout which is the one in look & feel you can use to set the main
> layout.
>
> This is interesting, in lib/init/smarty.php:455 the current object is
> checked for a tiki.object.layout attribute and will use that as the
> site_layout pref if there is one (who knew!? ;)
>
> This picks the dir inside templates/layouts where to look for tpls like
> layout_view.tpl and layout_edit.tpl... so, how about:
>
> You make a new dir in templates/layouts called plugin_pagelayout (for
> instance) and fork a copy of templates/layouts/basic/layout_view.tpl, which
> i think is the simplest one, and add the tests for your plugin settings as
> to whether to render the module zones or not?
>
> Not 100% sure how you would pass on those parameters, maybe with more
> attributes on the object (wiki page or whatever)? Would be ugly to use
> global smarty vars i think for this...
>
> Anyway, does that give you something to start on? Ping me if you want to
> discuss it or work out a better way...
>
> jonny
>
>
>
>
> > On 10 Jul 2018, at 16:24, Amna Usman <amna@genexbs.com> wrote:
> >
> > Thanks for the feedback Luci and Jonny,
> >
> > @Luci, I agree with your suggestions about simple parameters names. Will
> be easier for manual input.
> >
> > @Jonny: Will investigate it further, how to load custom Tpl via wiki
> plugin, instead of main Tpl, any reference plugin? I have checked AppFrame,
> its also using CSS/JS to hide elements.
> >
> > Thanks for having look.
> >
> > Regards
> > Amna Bilal
> >
> >
> > On Tue, Jul 10, 2018 at 6:32 PM Jonny Bradley <jonny@tiki.org> wrote:
> >>
> >> > On 10 Jul 2018, at 14:28, Jonny Bradley <jonny@tiki.org> wrote:
> >> >
> >> > Hi Anna
> >>
> >> Sorry Amna, it autocorrected! :P
> >>
> >> > and all
> >> >
> >> > Sorry i haven't had time to really investigate this but i think i
> agree that it might over complicate things to merge the two plugins now -
> the idea of appframe is that it's deliberately minimal in terms of
> parameters (like the list plugin), and you use sub-plugins to create your
> "app" background and features... so i don't think adding an arbitrary
> fgalId param for instance, to do a hard-coded slideshow background would be
> a good idea...
> >> >
> >> > One thought though, instead of using css to hide elements you don't
> want, why not use a different page layout template, so make a new version
> of templates/layouts/basic/layout_view.tpl for instance so if you're hiding
> the module zones it doesn't need to render them all and then hide them.
> Maybe it could be templates/layouts/internal/pagelayout_view.tpl or
> something?
> >> >
> >> > Will try and get back to you with more another day...
> >> >
> >> > Thanks :-)
> >> >
> >> > jonny
> >> >
> >> >
> >> >
> >> >
> >> >> On 10 Jul 2018, at 14:13, luciash <luci@tiki.org> wrote:
> >> >>
> >> >> Hi Amna,
> >> >>
> >> >> thank you! I am not sure if merge or not to merge (if merging would
> not make the two too complex and keep the old one still working on
> upgrades) but I have some feedback on the new plugin:
> >> >>
> >> >> Why not to make it simpler for users/developers?
> >> >>
> >> >> What about changing the params to:
> >> >>
> >> >> {pagelayout header="n" footer="n" leftcol="n" rightcol="n"
> fullwidth="y" width="70%" padding="3%" background="#000" contentbg="rgba(0,
> 0, 0, 0.8)" contentcolor="#fff" actions="n" fgalId="9"}
> >> >>
> >> >> And if you want to try the merge, perhaps merge the two plugins to
> different one first simply named plugin "Layout" (does it matter if it does
> not contain the word page or app)? So the syntax would be even simpler:
> >> >> {layout header="n" footer="n" leftcol="n" rightcol="n" fullwidth="y"
> width="70%" padding="3%" background="#000" contentbg="rgba(0, 0, 0, 0.8)"
> contentcolor="#fff" actions="n" fgalId="9"}
> >> >>
> >> >>
> >> >> HTH,
> >> >>
> >> >> luci
> >> >>
> >> >>
> >> >> On 10.07.2018 9:18, amna usman wrote:
> >> >>> Hi,
> >> >>>
> >> >>> Recently I have committed first version of pluginPageLayout in
> trunk, sample code to try out:
> >> >>>
> >> >>> {pagelayout pageHeader="n" pageFooter="n" pageLeftBar="n"
> pageRightBar="n" pageFullWidth="y" pageContentWidth="70%"
> pageContentPadding="3%" pageBackgroundColor="#000" contentBg="rgba(00, 00,
> 00, 0.8)" contentTextColor="#fff" pageActionButtons="n" fgalId="9"}
> >> >>>
> >> >>>
> >> >>>
> >> >>> And few demo links:
> >> >>> http://duedaily.com/trunk/tiki-index.php?page=PageLayout
> >> >>> http://duedaily.com/trunk/tiki-index.php?page=Login-Landing
> >> >>> http://duedaily.com/trunk/tiki-index.php?page=pageLayout-swiper
> >> >>>
> >> >>> Flicking issue in background images will be solved with preloading
> of images.
> >> >>>
> >> >>> Jonny pointed out this plugin is similar to PluginAppFrame, I have
> checked and here my findings:
> >> >>>
> >> >>> 1- AppFrame is placing a div over main body but its removing all
> page content.
> >> >>> 2- Keeping header and page action buttons.
> >> >>> 3- Also appFrame body content hides under action button bar (that
> needs to be fixed anyways)
> >> >>> 4- It basically giving blank canvas for user to fill in create page
> using body parameter of plugin.
> >> >>>
> >> >>> So we can:
> >> >>> 1- Either keep both separate (simple one pageLayout for simple
> hiding and backgrounds only) and appFrame for more complicated operations
> and advance users,
> >> >>> 2- Or can merge as Jonny suggested.
> >> >>>
> >> >>> For merge, additional options appFrame will have:
> >> >>> 1- Background colors
> >> >>> 2- File gallery slideshow
> >> >>> 3- Hide header and page action bars
> >> >>> 4- Use main body content if plugin body is empty, since its easier
> for users to compose page in editor rather than plugin body.
> >> >>>
> >> >>> Also my other concern was name of AppFrame that sounds more like
> application development rather than controlling page layout.
> >> >>>
> >> >>> Please vote if:
> >> >>>
> >> >>> 1- We should keep both plugins separate
> >> >>> 2- Or merge AppFrame and PluginPageLayout
> >> >>>
> >> >>>
> >> >>> Regards,
> >> >>> Amna Bilal
> >> >>>
> >> >>>
> >> >>>
> >> >>>
> ------------------------------------------------------------------------------
> >> >>> Check out the vibrant tech community on one of the world's most
> >> >>> engaging tech sites, Slashdot.org!
> >> >>> http://sdm.link/slashdot
> >> >>>
> >> >>>
> >> >>> ___
> >> >>> TikiWiki-devel mailing list
> >> >>>
> >> >>> TikiWiki-devel at lists.sourceforge.net
> >> >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >> >>
> >> >>
> ------------------------------------------------------------------------------
> >> >> Check out the vibrant tech community on one of the world's most
> >> >> engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot_
> >> >> TikiWiki-devel mailing list
> >> >> TikiWiki-devel at lists.sourceforge.net
> >> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > Check out the vibrant tech community on one of the world's most
> >> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> > ___
> >> > TikiWiki-devel mailing list
> >> > TikiWiki-devel at lists.sourceforge.net
> >> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >> >
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> TikiWiki-devel mailing list
> >> TikiWiki-devel at lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
> >
> ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot_
> > TikiWiki-devel mailing list
> > TikiWiki-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.