Tikiwiki-devel (mailman list mirror)

Change queue ( Partially persists: dev.tiki.org ticket modifications quietly lost)

Once solved, the following fields from ticket #6775 should be changed.
If wiki page x has a description (with preference feature_wiki_description) which contains a hotword, internal links ("wiki links" using the double parentheses syntax) to that page are broken. A ((x|label)) link to page x will display...
\{CODE(colors="null" theme="default")\}
Part of page description..." class="wiki wiki_page">label
... with a link to the hotword target on "Part of page description...", but no link to page x.

  1. Remove ":" from feature_hotwords_sep
  2. Remove "," from feature_hotwords_sep
  3. Remove hotwords from page descriptions
  4. Use external links rather than wiki links

The bug is in parse_data(). It parses wiki links (by calling parse_data_wikilinks()) before hotwords (by calling parse_data_inline_syntax(), via parse_data_process_maketoc()). The resulting HTML has an A element embedded in the normal A element:

<a href="x" title="Part of description before hotword
<a class="wiki" href="http://www.hotword.target" target='_blank'>Hotword</a>,
" class="wiki wiki_page">label</a>


mose added to replace_hotwords() a hack inserting a "
" sequence before and a ",
" sequence after each keyword in a description attribute to neutralize the hotword substitution (as described in the function's comments). But this hack was broken by revision 19319, since both of the characters in the magic sequences (the colon and the comma) are now part of the hotword separator characters (feature_hotwords_sep).


>De : Cloutier, Philippe (DGARI-Consultant)
>Envoyé : 6 septembre 2018 11:53
>I just tried my first item modification since I sent the previous message and it failed. I was trying to change the Category, Description and Importance fields of https://dev.tiki.org/item3455-Insert-an-image-with-editor
>Retrying field by field also fails, no matter which of the 3 fields I try.
>>De : Cloutier, Philippe (DGARI-Consultant) Envoyé : 5 septembre 2018
>>Ah, the Feature field also has something wrong. If I simply try to set it back to what it was ("All/Undefined" instead of "Search Engine Friendly (SEF)"), the change quietly fails.
>>I have reloaded all caches, even disabled caches, so this should not come from a stalled version of validator_tiki.js; however, Chrome's development tools are not showing that file in the Network tab (either directly or minified).
>>Can an admin disable feature_jquery_validation so we can at least confirm where to look?
>>>De : Cloutier, Philippe (DGARI-Consultant)
>>>Envoyé : 5 septembre 2018 12:46
>>>Thank you Marc,
>>>This seems to have solved part of the problem - I can no longer reproduce the exact last issue I described (changing the Feature field). But, I can still reproduce with the "Easy to solve?" field, and - surprisingly - at the first attempt, so that does not sound a regression from my May 2017 changes as I suspected. I reproduced with the same ticket as well as with another ticket chosen randomly, #6516, which is 2 on 2 tested. I can reproduce with both Google Chrome and Firefox.
>>>Can an admin confirm the issue persists with the "Easy to solve?" field even when potential permission issues are excluded? And can anyone see where this issue would come from?
>>>If not, can anyone remember when they last successfully changed the "Easy to solve?" field?
>>>>De : Marc Laporte mailto:marc@marclaporte.com Envoyé : 5 septembre
>>>>2018 09:02
>>>> https://dev.tiki.org/ has just been updated
>>>>On Wed, Sep 5, 2018 at 6:56 AM, Victor Emanouilov <victor@tiki.org> wrote:
>>>>> Hi all,
>>>>> I just submitted a fix regarding this:
>>>>> https://tiki.org/tiki-view_forum_thread.php?forumId=26&comments_par
>>>>> e
>>>>> n
>>>>> t
>>>>> Id=69861
>>>>> It was related to the jquery ajax validation of some of the input
>>>>> fields and form being submitted without the submit button key/value pair after that.
>>>>> Regards,
>>>>> Victor

TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net

Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.