All good questions, i'll reply inline down there...
> On 5 Nov 2018, at 23:19, Jean-Marc Libs <email@example.com> wrote:
> Hi devs,
> Upon testing upgrades from Tiki 15 to tiki 19, I had a good look at vendor/autoload-disabled-README.txt as prompted by running sh setup.sh
> (I should have done this for Tiki18 but I had less time)
> These are the explanations I saw. Below, I have 2 questions in order to mak sure I understand
> Your vendor folder contains multiple packages that were normally bundled with Tiki. Since version 17 those libraries
> were migrated from the folder "vendor" to the folder "vendor_bundled".
> It looks like your instance still has these libraries in the vendor folder, to avoid issues your "vendor/autoload.php"
> was renamed to "vendor/autoload-disabled.php".
> If you are sure that want to use the libraries in addition to the ones bundled with tiki, please rename back your
> "vendor/autoload.php" and place a file with the name "do_not_clean.txt" in the vendor folder.
> Tiki will not load your "vendor/autoload.php" when is detected as being a stalled folder unless a file called
> "vendor/do_not_clean.txt" exists. That will also prevent, in future runs of composer, the automatic disabling of
> Fist question:
> I see the instructions for " If you are sure that want to use the libraries in addition to the ones bundled with tiki " but why would I?
Maybe if you had added your own packages in there, like mPDF or something then you might need them. I guess it should say that maybe? Personally i always used something like vendor_custom for my custom additions due to running with svn checkouts, but i guess if you have a tarball install then using the default composer location for adding stuff might make sense?
> The instructions I miss are the one for the happy path: I am quite happy that all required packages are in vendor_bundled, so what do I do now?
> * " rm -rf vendor " ? Tiki still runs fine but I'm concerned the directory might not be recreated if I install additional packages later.
> * " rm -rf vendor/* " ?
I guess if there's nothing in there you need deleting it makes sense, setup.sh will remake it and set the perms right so you can use the new package manager to install what you need in there afterwards.
> Second question very short question:
> " stalled folder " should read " stale folder ", shouldn't it?
Not sure, neither word makes great sense to me... i guess i didn't read it properly!
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net