Loading...
 

Tikiwiki-devel (mailman list mirror)


jQuery Chosen dropdown arrow issue

Hi Gary,

I think it is done now. Fixed by a commit by Xorti iirc.

Thanks,

luci



On 09.11.2018 4:43, Gary Cunningham-Lee wrote:
> Hi again luci,
>
> What is the solution, then? Can sass-svg-uri be removed/avoided
> somehow, or do we stay with the workaround?
>
> — Gary
>
> On 11/6/2018 2:21 PM, Gary Cunningham-Lee wrote:
>> Hi luci,
>>
>> When I  remove (renamed actually so it isn't found)
>> npm-asset/sass-svg-uri, and also comment out my workaround lines, the
>> Chosen up and down arrows and the delete "x" do display as they
>> should, so it looks like you did indeed pinpoint the culprit.
>>
>> — Gary
>>
>> On 11/1/2018 7:17 PM, luciash wrote:
>>> Hi Gary,
>>>
>>> I mean in this thread:
>>> https://sourceforge.net/p/tikiwiki/mailman/message/36454383/
>>>
>>> Can you confirm if you remove that "sass-svg-uri" from
>>> vendor_bundled/vendor/npm-asset/ and recompile themes that the
>>> Chosen SVG graphics work even without your hardcoded workaround?
>>>
>>> Thanks,
>>>
>>> luci
>>>
>>>
>>> On 31.10.2018 23:51, Gary Cunningham-Lee wrote:
>>>> Hi,
>>>>
>>>> Sorry, I'm not sure what you mean or how to go about confirming.
>>>>
>>>> — Gary
>>>>
>>>> On 10/30/2018 11:28 PM, luciash wrote:
>>>>> Hi Gary,
>>>>>
>>>>> I think I pinpointed the culprit in the sass-svg-uri thread. Can
>>>>> you confirm please?
>>>>>
>>>>> luci
>>>>>
>>>>>
>>>>> On 31.10.2018 6:45, Gary Cunningham-Lee wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 10/30/2018 12:02 PM, Cloutier, Philippe (DGARI-Consultant) wrote:
>>>>>>> This issue was worked around by r68163.
>>>>>>
>>>>>> Yes, that's right, but the workaround was just to copy the CSS
>>>>>> from the DOM inspector view of the author's demo page into Tiki's
>>>>>> SCSS/CSS, so is not a very nice fix. It would be good to find
>>>>>> what's breaking Tiki's implementation of the script.
>>>>>>
>>>>>> By the way, I've got a similar fix for the up arrow in the
>>>>>> selector and for the delete "x" icon in the multiple selector,
>>>>>> but SF isn't accepting my normal authentication at the moment so
>>>>>> can't commit it yet.
>>>>>>
>>>>>>>
>>>>>>>> De : Gary Cunningham-Lee mailto:gary_c@cunningham-lee.com
>>>>>>>> Envoyé : 27 septembre 2018 10:31
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> We noticed that the dropdown arrow is missing in Chosen
>>>>>>>> dropdowns in trunk.
>>>>>>>
>>>>>>> I reported a similar issue to tikiwiki-devel today in thread
>>>>>>> "Small regression from Tiki 18: no contrast in multiple choice
>>>>>>> select tracker field list form". The cause may be the same.
>>>>>>>
>>>>>>>> The DOM inspector shows:
>>>>>>>>
>>>>>>>> background-image: svg-uri("<svg xmlns='http://www.w3.org/2000/svg'

>>>>>>>> viewBox='0 0 24 24'><path fill='#adb5bd' d='M7.41 7.84L12

>>>>>>>> 12.42l4.59-4.58L18 9.25l-6 6-6-6z'/></svg>");
>>>>>>>>
>>>>>>>> But the Firefox DOM inspector reports an error: Improper
>>>>>>>> property value.
>>>>>>>
>>>>>>>
>>>>>>> Hum, no precision on which property? :-/
>>>>>>>
>>>>>>>> So I checked at the bootstrap4c-chosen author's website -
>>>>>>>> https://haubek.github.io/chosen/ . There, the dropdown arrow
>>>>>>>> code is this:
>>>>>>>>
>>>>>>>> background-image: url("data:image/svg+xml;charset=utf8,%3Csvg
>>>>>>>> xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24
>>>>>>>> 24'%3E%3Cpath fill='%23adb5bd' d='M7.41 7.84L12
>>>>>>>> 12.42l4.59-4.58L18 9.25l-6 6-6-6z'/%3E%3C/svg%3E");
>>>>>>>>
>>>>>>>> It displays, and there's no error. So I'm wondering if our
>>>>>>>> version of haubek/boogtstrap4c-chosen needs updating.
>>>>>>>
>>>>>>>
>>>>>>> I'm afraid it's not just that. We're on 1.0.13, that's the
>>>>>>> latest upstream version, and there's no commit after.
>>>>>>
>>>>>> Ok, I was just speculating as I didn't know how else to account
>>>>>> for the difference in the rendered page between the script
>>>>>> author's demo and the Tiki implementation.
>>>>>>
>>>>>>>
>>>>>>>> — Gary
>>>>>>>
>>>>>>>
>>>>>>> ___
>>>>>>> TikiWiki-devel mailing list
>>>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ___
>>>>>> TikiWiki-devel mailing list
>>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>>
>>>>>
>>>>>
>>>>> ___
>>>>> TikiWiki-devel mailing list
>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>
>>>>
>>>>
>>>> ___
>>>> TikiWiki-devel mailing list
>>>> TikiWiki-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>
>>>
>>>
>>> ___
>>> TikiWiki-devel mailing list
>>> TikiWiki-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>>
>>
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Ah sorry,

apparently I just dreamed about it. Actually I mixed it up with the
http://sourceforge.net/p/tikiwiki/code/68269 ;)

Yes, I think it should be actually removed.

luci


On 09.11.2018 11:48, luciash wrote:
> Hi Gary,
>
> I think it is done now. Fixed by a commit by Xorti iirc.
>
> Thanks,
>
> luci
>
>
>
> On 09.11.2018 4:43, Gary Cunningham-Lee wrote:
>> Hi again luci,
>>
>> What is the solution, then? Can sass-svg-uri be removed/avoided
>> somehow, or do we stay with the workaround?
>>
>> — Gary
>>
>> On 11/6/2018 2:21 PM, Gary Cunningham-Lee wrote:
>>> Hi luci,
>>>
>>> When I  remove (renamed actually so it isn't found)
>>> npm-asset/sass-svg-uri, and also comment out my workaround lines,
>>> the Chosen up and down arrows and the delete "x" do display as they
>>> should, so it looks like you did indeed pinpoint the culprit.
>>>
>>> — Gary
>>>
>>> On 11/1/2018 7:17 PM, luciash wrote:
>>>> Hi Gary,
>>>>
>>>> I mean in this thread:
>>>> https://sourceforge.net/p/tikiwiki/mailman/message/36454383/
>>>>
>>>> Can you confirm if you remove that "sass-svg-uri" from
>>>> vendor_bundled/vendor/npm-asset/ and recompile themes that the
>>>> Chosen SVG graphics work even without your hardcoded workaround?
>>>>
>>>> Thanks,
>>>>
>>>> luci
>>>>
>>>>
>>>> On 31.10.2018 23:51, Gary Cunningham-Lee wrote:
>>>>> Hi,
>>>>>
>>>>> Sorry, I'm not sure what you mean or how to go about confirming.
>>>>>
>>>>> — Gary
>>>>>
>>>>> On 10/30/2018 11:28 PM, luciash wrote:
>>>>>> Hi Gary,
>>>>>>
>>>>>> I think I pinpointed the culprit in the sass-svg-uri thread. Can
>>>>>> you confirm please?
>>>>>>
>>>>>> luci
>>>>>>
>>>>>>
>>>>>> On 31.10.2018 6:45, Gary Cunningham-Lee wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 10/30/2018 12:02 PM, Cloutier, Philippe (DGARI-Consultant)
>>>>>>> wrote:
>>>>>>>> This issue was worked around by r68163.
>>>>>>>
>>>>>>> Yes, that's right, but the workaround was just to copy the CSS
>>>>>>> from the DOM inspector view of the author's demo page into
>>>>>>> Tiki's SCSS/CSS, so is not a very nice fix. It would be good to
>>>>>>> find what's breaking Tiki's implementation of the script.
>>>>>>>
>>>>>>> By the way, I've got a similar fix for the up arrow in the
>>>>>>> selector and for the delete "x" icon in the multiple selector,
>>>>>>> but SF isn't accepting my normal authentication at the moment so
>>>>>>> can't commit it yet.
>>>>>>>
>>>>>>>>
>>>>>>>>> De : Gary Cunningham-Lee mailto:gary_c@cunningham-lee.com
>>>>>>>>> Envoyé : 27 septembre 2018 10:31
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> We noticed that the dropdown arrow is missing in Chosen
>>>>>>>>> dropdowns in trunk.
>>>>>>>>
>>>>>>>> I reported a similar issue to tikiwiki-devel today in thread
>>>>>>>> "Small regression from Tiki 18: no contrast in multiple choice
>>>>>>>> select tracker field list form". The cause may be the same.
>>>>>>>>
>>>>>>>>> The DOM inspector shows:
>>>>>>>>>
>>>>>>>>> background-image: svg-uri("<svg
>>>>>>>>> xmlns='http://www.w3.org/2000/svg'

>>>>>>>>> viewBox='0 0 24 24'><path fill='#adb5bd' d='M7.41 7.84L12

>>>>>>>>> 12.42l4.59-4.58L18 9.25l-6 6-6-6z'/></svg>");
>>>>>>>>>
>>>>>>>>> But the Firefox DOM inspector reports an error: Improper
>>>>>>>>> property value.
>>>>>>>>
>>>>>>>>
>>>>>>>> Hum, no precision on which property? :-/
>>>>>>>>
>>>>>>>>> So I checked at the bootstrap4c-chosen author's website -
>>>>>>>>> https://haubek.github.io/chosen/ . There, the dropdown arrow
>>>>>>>>> code is this:
>>>>>>>>>
>>>>>>>>> background-image: url("data:image/svg+xml;charset=utf8,%3Csvg
>>>>>>>>> xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24
>>>>>>>>> 24'%3E%3Cpath fill='%23adb5bd' d='M7.41 7.84L12
>>>>>>>>> 12.42l4.59-4.58L18 9.25l-6 6-6-6z'/%3E%3C/svg%3E");
>>>>>>>>>
>>>>>>>>> It displays, and there's no error. So I'm wondering if our
>>>>>>>>> version of haubek/boogtstrap4c-chosen needs updating.
>>>>>>>>
>>>>>>>>
>>>>>>>> I'm afraid it's not just that. We're on 1.0.13, that's the
>>>>>>>> latest upstream version, and there's no commit after.
>>>>>>>
>>>>>>> Ok, I was just speculating as I didn't know how else to account
>>>>>>> for the difference in the rendered page between the script
>>>>>>> author's demo and the Tiki implementation.
>>>>>>>
>>>>>>>>
>>>>>>>>> — Gary
>>>>>>>>
>>>>>>>>
>>>>>>>> ___
>>>>>>>> TikiWiki-devel mailing list
>>>>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ___
>>>>>>> TikiWiki-devel mailing list
>>>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>>>
>>>>>>
>>>>>>
>>>>>> ___
>>>>>> TikiWiki-devel mailing list
>>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>>
>>>>>
>>>>>
>>>>> ___
>>>>> TikiWiki-devel mailing list
>>>>> TikiWiki-devel at lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>>
>>>>
>>>>
>>>> ___
>>>> TikiWiki-devel mailing list
>>>> TikiWiki-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>>
>>>
>>>
>>> ___
>>> TikiWiki-devel mailing list
>>> TikiWiki-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>>
>>
>> ___
>> TikiWiki-devel mailing list
>> TikiWiki-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>
>
> ___
> TikiWiki-devel mailing list
> TikiWiki-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel



___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel


Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.