Loading...
 

Tikiwiki-devel (mailman list mirror)


[Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[69010] branches/19.x/templates/tiki-wiki_topline.tpl

Hi Bernard,

>De : Bsfez Tiki mailto:bsfez@tiki.org
>Envoyé : 12 février 2019 01:24
>
>Hi,
>
>...
>
>
>Bernard
>
>PS: why a cog icon for the action menu, isn't a cog for setting ?


Good question. For a technical answer, that follows from r67527... so I just replied to that commit.

>>On 12 Feb 2019, at 00:52 , Cloutier, Philippe (DGARI-Consultant) <Philippe.Cloutier.externe@mern-mffp.gouv.qc.ca> wrote:

>>
>>I believe these class names were recycled from Bootstrap stuff. In this case, the actual meaning of btn-primary is not primary, but "Make a significant non-destructive change", according to https://themes.tiki.org/Organization-of-button-colors-in-Tiki
>>Which means there can be several primary buttons…
>>
>>I doubt any of the classes will apply though. I guess there should be no color, or the same color as other "action" dropdowns.
>>
>>
>>>De : Jonny Bradley mailto:jonny@tiki.org
>>>Envoyé : 9 février 2019 09:11
>>>À : Tiki developers <tikiwiki-devel@lists.sourceforge.net>
>>>Objet : Re: Tiki-devel Tikiwiki-cvs/svn SF.net SVN: tikiwiki:69010 branches/19.x/templates/tiki-wiki_topline.tpl
>>>
>>>Hi Luci
>>>
>>>Replying on the dev list for wider participation :-)
>>>
>>>Hmm, but there are other "primary" buttons already on the page, like edit, rename etc, shouldn't they be the "primary" one/s?
>>>
>>>And that button group looks like one thing, so i think looks bad (confusing) when it's multi-coloured. To me it does seem like "info" because it reveals more options (like short url, print and favourite) in the same way the translation one reveals (quite important) translation tools...
>>>
>>>Attached is a screenie using the "United" theme with primary on the actions button, with the translations menu showing:
>>>
>>><image001.png>
>>>
>>>...but what do others think? (i'll revert it if that's what everyone wants, of course)
>>>
>>>jonny
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>>On 9 Feb 2019, at 13:48, luciash <luci@tiki.org> wrote:
>>>>
>>>>IMHO only one should be primary, and that is the actions dropdown (as it
>>>>was), the others are info, because they do not have primary function,
>>>>like e.g. the backlinks inform about pages which link to this page?
>>>>
>>>>luci
>>>>
>>>>
>>>>>On 08.02.2019 19:58, jonnybradley--- via Tikiwiki-cvs wrote:
>>>>>
>>>>>
>>>>>Revision: 69010
>>>>> http://sourceforge.net/p/tikiwiki/code/69010
>>>>>Author: jonnybradley
>>>>>Date: 2019-02-08 18:58:54 +0000 (Fri, 08 Feb 2019)
>>>>>Log Message:
>>>>>-----------
>>>>>FIX bs4: Better class for page actions dropdown button, so it matches the other ones, or should they all be primary?
>>>>>
>>>>>Modified Paths:
>>>>>--------------
>>>>> branches/19.x/templates/tiki-wiki_topline.tpl
>>>>>
>>>>>Modified: branches/19.x/templates/tiki-wiki_topline.tpl
>>>>>=============
>>>>>--- branches/19.x/templates/tiki-wiki_topline.tpl 2019-02-08 18:56:23 UTC (rev 69009)
>>>>>+++ branches/19.x/templates/tiki-wiki_topline.tpl 2019-02-08 18:58:54 UTC (rev 69010)
>>>>>@@ -121,7 +121,7 @@
>>>>> \{assign var="hasPageAction" value="0"\}
>>>>> \{capture name="pageActions"\}

>>>>> \{if ! $js}<ul class="cssmenu_horiz"><li>{/if\}

>>>>>- <a class="btn btn-primary btn-sm dropdown-toggle" data-toggle="dropdown" data-hover="dropdown" href="#" title="\{tr}Page actions{/tr\}">
>>>>>+ <a class="btn btn-info btn-sm dropdown-toggle" data-toggle="dropdown" data-hover="dropdown" href="#" title="\{tr}Page actions{/tr\}">
>>>>> \{icon name="cog"\}
>>>>> </a>

>>>>> <div class="dropdown-menu dropdown-menu-right">


___
TikiWiki-devel mailing list
TikiWiki-devel at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel

Why Register?

Register at tiki.org and you'll be able to use the account at any *.tiki.org site, thanks to the InterTiki feature. A valid email address is required to receive site notifications and occasional newsletters. You can opt out of these items at any time.