Loading...
 
Skip to main content

Galaxia Workflow Engine

Forum List Topic List

Forums » Galaxia Workflow Engine » More patches for Galaxia
 
Thread actions
Print this page
  • Print all pages

    • More patches for Galaxia

    Posted by Georger Araujo Brazil

    Hi,
    I've collected all fixes I and others made to Galaxia and posted them here. The list of fixes goes below. Regards,

    Georger

    Thanks to (in no particular order): the original Galaxia devs, smalcolm, Gremo, ashuap, pemen, klaus.h, and everyone else who contributed!

    1) tiki-g-admin_activities.php
    Do not allow blank names when adding new activities or roles in the Admin process activities screen.

    2) tiki-g-admin_graph.php
    Changed $info'graph'external link to that it would contain an URL to the graph image file instead of an absolute filesystem path.

    3) tiki-g-admin_instance_activity.php
    Remove debug echo statements.

    4) tiki-g-monitor_workitems.php
    Specify from which table we're querying instanceId when filtering in the Monitor workitems screen.

    5) tiki-g-user_instances.php
    Replace useless 'Process Name' filter with 'Instance Name' filter.

    6) lib\Galaxia\config.php
    Rewrote galaxia_execute_activity so that we don't need fopen() in order to run non-interactive activities.

    7) lib\Galaxia\config.tikiwiki.php
    Rewrote galaxia_execute_activity so that we don't need fopen() in order to run non-interactive activities.

    8) lib\Galaxia\src\API\BaseActivity.php
    Add and initialize missing expirationTime property.

    9) lib\Galaxia\src\API\Instance.php
    Fix setOwner method and handling of join activities.

    10) lib\Galaxia\src\GUI\GUI.php
    Make gui_list_user_instances() return instance name.

    11) lib\Galaxia\src\ProcessManager\ActivityManager.php
    Return array containing mapped roles for a given activity in list_activities() along with the other data.

    12) lib\Galaxia\src\ProcessManager\GraphViz.php
    Patched image_and_map() function to add the proper quotes in the outputh file paths when running on Windows. Fixes graph image file generation on Windows, as long as Graphviz binaries can be found in the PATH environment variable. The setup program for Graphviz adds the installation folder to PATH, so it shouldn't be a problem.

    13) lib\Galaxia\src\ProcessMonitor\ProcessMonitor.php
    Improve monitor_list_workitems() in order to add instance name and status and fix elapsed time in Monitor workitems screen.

    14) templates\tiki-g-activity_completed.tpl
    Change 'Title' label to 'Subject' on the comment screen.

    15) templates\tiki-g-admin_activities.tpl
    Add role to filter options in the Admin process activities screen.

    16) templates\tiki-g-admin_shared_source.tpl
    Add missing ) to 'Process form' code block.

    17) templates\tiki-g-monitor_workitems.tpl
    Add Instance name and status and fix elapsed time in Monitor workitems screen.

    18) templates\tiki-g-user_activities.tpl
    Don't prompt for instance name on standalone activities.

    19) templates\tiki-g-user_instances.tpl
    Add column to sort by meaningful instance name instead of confusing instance Id.

    Reads: 2257
    Posted by Marc Laporte Canada

    > Hi,
    > I've collected all fixes I and others made to Galaxia and posted them here. The list of fixes goes below. Regards,
    >


    Excellent!!

    These are all or will soon be in BRANCH-1-9 and therefore released in Tiki 1.9.3?

    Thanks!

    M 😉

    Posted by Georger Araujo Brazil

    > Excellent!!
    >
    > These are all or will soon be in BRANCH-1-9 and therefore released in Tiki 1.9.3?
    >
    > Thanks!
    >
    > M 😉

    Yes - I already committed all of them to CVS 😀
    I made these patches available separately so those interested can get and use them right away. Regards,

    Georger


    Posted by Gremo

    Hi georger,
    Thanks for your work! 😉

    but i have a little problem applaying patch "tikiwiki now no needs fopen to execute no-interactive activities".
    I'm developing outside tikiwiki, so i have a galaxia.api.inc.php ( included) structured like this:

    1)constraints (GALAXIA LIBRARY, ETC..)
    2)libraries (gui, instance, processmonitor, etc)
    3)function "galaxia_execute_activity" (replaced with yours)


    i get this error:

    "Fatal error: Using $this when not in object context "


    i suppose on first line...

    // Now execute the code for the activity but we are in a method!
    $activityname = $this->getOne("select `normalized_name` from `" . GALAXIA_TABLE_PREFIX .

    what do you think the problem is?
    Thanks

    Gremo

    Posted by Georger Araujo Brazil

    > Hi georger,
    > Thanks for your work! 😉
    >
    > but i have a little problem applaying patch "tikiwiki now no needs fopen to execute no-interactive activities".
    > I'm developing outside tikiwiki, so i have a galaxia.api.inc.php ( included) structured like this:
    >
    > 1)constraints (GALAXIA LIBRARY, ETC..)
    > 2)libraries (gui, instance, processmonitor, etc)
    > 3)function "galaxia_execute_activity" (replaced with yours)
    >
    > i get this error:
    >
    > "Fatal error: Using $this when not in object context "
    >
    > i suppose on first line...
    >
    > // Now execute the code for the activity but we are in a method!
    > $activityname = $this->getOne("select `normalized_name` from `" . GALAXIA_TABLE_PREFIX .
    >
    > what do you think the problem is?
    > Thanks
    >
    > Gremo

    Hmm,
    I think it's because galaxia_execute_activity() does not have the same includes as tiki-g-run_activity.php. I modified the function to have these includes, and tested it. All worked fine. I committed the change to CVS and you can get it from there. If you can't get it from CVS, here goes the modified function:

    Image
    Copy to clipboard
    function galaxia_execute_activity($activityId = 0, $iid = 0, $auto = 1)
    {
		// Use the same includes as tiki-g-run_activity.php in order to obtain context info
		include ('tiki-setup.php');

		include ('lib/Galaxia/API.php');
		include_once ("lib/webmail/htmlMimeMail.php");

		$__activity_completed = false;
		
		// Determine the activity using the activityId request parameter and get the activity information
		// load then the compiled version of the activity
		if (!isset($_REQUEST['activityId'])) {
			$smarty->assign('msg', tra("No activity indicated"));

			$smarty->display("error.tpl");
			die;
		}

		$activity = $baseActivity->getActivity($_REQUEST['activityId']);
		$process->getProcess($activity->getProcessId());

		if (!isset($_REQUEST['__post'])) {
			$shared = 'lib/Galaxia/processes/' . $process->getNormalizedName(). '/code/shared.php';
			$source = 'lib/Galaxia/processes/' . $process->getNormalizedName(). '/compiled/' . $activity->getNormalizedName(). '.php';

			// Existing variables here:
			// $process, $activity, $instance (if not standalone)
			// Include the shared code
			include_once ($shared);

			// Now do whatever you have to do in the activity
			include_once ($source);
		}
    }



    Regards,

    Georger


    Posted by Georger Araujo Brazil

    UPDATE: I've found problems with changes #6 and #7, please revert to the former files. I've committed the original files to CVS and I'm updating the ZIP on savefile.com.

    Georger

    > Hi,
    > I've collected all fixes I and others made to Galaxia and posted them here. The list of fixes goes below. Regards,
    >
    > Georger
    >
    > Thanks to (in no particular order): the original Galaxia devs, smalcolm, Gremo, ashuap, pemen, klaus.h, and everyone else who contributed!
    >
    > 1) tiki-g-admin_activities.php
    > Do not allow blank names when adding new activities or roles in the Admin process activities screen.
    >
    > 2) tiki-g-admin_graph.php
    > Changed $info'graph'external link to that it would contain an URL to the graph image file instead of an absolute filesystem path.
    >
    > 3) tiki-g-admin_instance_activity.php
    > Remove debug echo statements.
    >
    > 4) tiki-g-monitor_workitems.php
    > Specify from which table we're querying instanceId when filtering in the Monitor workitems screen.
    >
    > 5) tiki-g-user_instances.php
    > Replace useless 'Process Name' filter with 'Instance Name' filter.
    >
    > 6) lib\Galaxia\config.php
    > Rewrote galaxia_execute_activity so that we don't need fopen() in order to run non-interactive activities.
    >
    > 7) lib\Galaxia\config.tikiwiki.php
    > Rewrote galaxia_execute_activity so that we don't need fopen() in order to run non-interactive activities.
    >
    > 8) lib\Galaxia\src\API\BaseActivity.php
    > Add and initialize missing expirationTime property.
    >
    > 9) lib\Galaxia\src\API\Instance.php
    > Fix setOwner method and handling of join activities.
    >
    > 10) lib\Galaxia\src\GUI\GUI.php
    > Make gui_list_user_instances() return instance name.
    >
    > 11) lib\Galaxia\src\ProcessManager\ActivityManager.php
    > Return array containing mapped roles for a given activity in list_activities() along with the other data.
    >
    > 12) lib\Galaxia\src\ProcessManager\GraphViz.php
    > Patched image_and_map() function to add the proper quotes in the outputh file paths when running on Windows. Fixes graph image file generation on Windows, as long as Graphviz binaries can be found in the PATH environment variable. The setup program for Graphviz adds the installation folder to PATH, so it shouldn't be a problem.
    >
    > 13) lib\Galaxia\src\ProcessMonitor\ProcessMonitor.php
    > Improve monitor_list_workitems() in order to add instance name and status and fix elapsed time in Monitor workitems screen.
    >
    > 14) templates\tiki-g-activity_completed.tpl
    > Change 'Title' label to 'Subject' on the comment screen.
    >
    > 15) templates\tiki-g-admin_activities.tpl
    > Add role to filter options in the Admin process activities screen.
    >
    > 16) templates\tiki-g-admin_shared_source.tpl
    > Add missing ) to 'Process form' code block.
    >
    > 17) templates\tiki-g-monitor_workitems.tpl
    > Add Instance name and status and fix elapsed time in Monitor workitems screen.
    >
    > 18) templates\tiki-g-user_activities.tpl
    > Don't prompt for instance name on standalone activities.
    >
    > 19) templates\tiki-g-user_instances.tpl
    > Add column to sort by meaningful instance name instead of confusing instance Id.